Re: [PATCH v6 2/2] regulator: add QCOM RPMh regulator driver

2018-06-08 Thread David Collins
Hello Matthias, On 06/07/2018 05:26 PM, Matthias Kaehlcke wrote: > On Mon, Jun 04, 2018 at 12:15:12PM -0700, David Collins wrote: >> static int rpmh_regulator_send_request(struct rpmh_vreg *vreg, >> + struct tcs_cmd *cmd, int count, bool wait_for_ack) >> > > nit: as of now t

Re: [PATCH v6 2/2] regulator: add QCOM RPMh regulator driver

2018-06-07 Thread Matthias Kaehlcke
Hi David, On Mon, Jun 04, 2018 at 12:15:12PM -0700, David Collins wrote: > Add the QCOM RPMh regulator driver to manage PMIC regulators > which are controlled via RPMh on some Qualcomm Technologies, Inc. > SoCs. RPMh is a hardware block which contains several > accelerators which are used to mana

Re: [PATCH v6 2/2] regulator: add QCOM RPMh regulator driver

2018-06-06 Thread Doug Anderson
Hi, On Mon, Jun 4, 2018 at 12:15 PM, David Collins wrote: > Add the QCOM RPMh regulator driver to manage PMIC regulators > which are controlled via RPMh on some Qualcomm Technologies, Inc. > SoCs. RPMh is a hardware block which contains several > accelerators which are used to manage various har

[PATCH v6 2/2] regulator: add QCOM RPMh regulator driver

2018-06-04 Thread David Collins
Add the QCOM RPMh regulator driver to manage PMIC regulators which are controlled via RPMh on some Qualcomm Technologies, Inc. SoCs. RPMh is a hardware block which contains several accelerators which are used to manage various hardware resources that are shared between the processors of the SoC.