Re: [PATCH v6 2/3] input: tm2-touchkey: Add touchkey driver support for TM2

2017-01-15 Thread Jaechul Lee
Dear Dmitry Torokhov, On Sat, Jan 14, 2017 at 11:11:10PM -0800, Dmitry Torokhov wrote: > Hi Jaechul, > > On Mon, Jan 09, 2017 at 04:22:14PM +0900, Jaechul Lee wrote: > > +static irqreturn_t tm2_touchkey_irq_handler(int irq, void *devid) > > +{ > > + struct tm2_touchkey_data *touchkey = devid;

Re: [PATCH v6 2/3] input: tm2-touchkey: Add touchkey driver support for TM2

2017-01-15 Thread Jaechul Lee
Dear Dmitry Torokhov, On Sat, Jan 14, 2017 at 11:11:10PM -0800, Dmitry Torokhov wrote: > Hi Jaechul, > > On Mon, Jan 09, 2017 at 04:22:14PM +0900, Jaechul Lee wrote: > > +static irqreturn_t tm2_touchkey_irq_handler(int irq, void *devid) > > +{ > > + struct tm2_touchkey_data *touchkey = devid;

Re: [PATCH v6 2/3] input: tm2-touchkey: Add touchkey driver support for TM2

2017-01-14 Thread Dmitry Torokhov
Hi Jaechul, On Mon, Jan 09, 2017 at 04:22:14PM +0900, Jaechul Lee wrote: > +static irqreturn_t tm2_touchkey_irq_handler(int irq, void *devid) > +{ > + struct tm2_touchkey_data *touchkey = devid; > + u32 data; > + > + data = i2c_smbus_read_byte_data(touchkey->client, > +

Re: [PATCH v6 2/3] input: tm2-touchkey: Add touchkey driver support for TM2

2017-01-14 Thread Dmitry Torokhov
Hi Jaechul, On Mon, Jan 09, 2017 at 04:22:14PM +0900, Jaechul Lee wrote: > +static irqreturn_t tm2_touchkey_irq_handler(int irq, void *devid) > +{ > + struct tm2_touchkey_data *touchkey = devid; > + u32 data; > + > + data = i2c_smbus_read_byte_data(touchkey->client, > +

Re: [PATCH v6 2/3] input: tm2-touchkey: Add touchkey driver support for TM2

2017-01-08 Thread Chanwoo Choi
Hi Jaechul, Looks good to me. I tested this patch on TM2 board. It is well working. Reviewed-by: Chanwoo Choi Tested-by: Chanwoo Choi Best Regards, Chanwoo Choi On 2017년 01월 09일 16:22, Jaechul Lee wrote: > This patch adds support for the TM2

Re: [PATCH v6 2/3] input: tm2-touchkey: Add touchkey driver support for TM2

2017-01-08 Thread Chanwoo Choi
Hi Jaechul, Looks good to me. I tested this patch on TM2 board. It is well working. Reviewed-by: Chanwoo Choi Tested-by: Chanwoo Choi Best Regards, Chanwoo Choi On 2017년 01월 09일 16:22, Jaechul Lee wrote: > This patch adds support for the TM2 touch key and led > functionality. > > The driver

[PATCH v6 2/3] input: tm2-touchkey: Add touchkey driver support for TM2

2017-01-08 Thread Jaechul Lee
This patch adds support for the TM2 touch key and led functionality. The driver interfaces with userspace through an input device and reports KEY_PHONE and KEY_BACK event types. LED brightness can be controlled by "/sys/class/leds/tm2-touchkey/brightness". Signed-off-by: Beomho Seo

[PATCH v6 2/3] input: tm2-touchkey: Add touchkey driver support for TM2

2017-01-08 Thread Jaechul Lee
This patch adds support for the TM2 touch key and led functionality. The driver interfaces with userspace through an input device and reports KEY_PHONE and KEY_BACK event types. LED brightness can be controlled by "/sys/class/leds/tm2-touchkey/brightness". Signed-off-by: Beomho Seo