Re: [PATCH v6 2/3] media: i2c: imx274: Remove stop stream i2c writes during remove

2020-09-24 Thread Sakari Ailus
On Thu, Sep 24, 2020 at 12:09:22PM +0200, Luca Ceresoli wrote: > On 22/09/20 10:47, Sakari Ailus wrote: > > Hi Luca, > > > > On Tue, Sep 22, 2020 at 10:09:33AM +0200, Luca Ceresoli wrote: > >> Hi, > >> > >> On 21/09/20 23:39, Sowjanya Komatineni wrote: > >>> Sensor should already be in standby dur

Re: [PATCH v6 2/3] media: i2c: imx274: Remove stop stream i2c writes during remove

2020-09-24 Thread Luca Ceresoli
On 22/09/20 10:47, Sakari Ailus wrote: > Hi Luca, > > On Tue, Sep 22, 2020 at 10:09:33AM +0200, Luca Ceresoli wrote: >> Hi, >> >> On 21/09/20 23:39, Sowjanya Komatineni wrote: >>> Sensor should already be in standby during remove and there is no >>> need to configure sensor registers for stream st

Re: [PATCH v6 2/3] media: i2c: imx274: Remove stop stream i2c writes during remove

2020-09-22 Thread Sakari Ailus
Hi Luca, On Tue, Sep 22, 2020 at 10:09:33AM +0200, Luca Ceresoli wrote: > Hi, > > On 21/09/20 23:39, Sowjanya Komatineni wrote: > > Sensor should already be in standby during remove and there is no > > need to configure sensor registers for stream stop. > > I beg your pardon for the newbie quest

Re: [PATCH v6 2/3] media: i2c: imx274: Remove stop stream i2c writes during remove

2020-09-22 Thread Luca Ceresoli
Hi, On 21/09/20 23:39, Sowjanya Komatineni wrote: > Sensor should already be in standby during remove and there is no > need to configure sensor registers for stream stop. I beg your pardon for the newbie question: does the V4L2 framework guarantee that the stream is stopped (.s_stream(..., 0)) b

Re: [PATCH v6 2/3] media: i2c: imx274: Remove stop stream i2c writes during remove

2020-09-22 Thread Thierry Reding
On Mon, Sep 21, 2020 at 02:39:38PM -0700, Sowjanya Komatineni wrote: > Sensor should already be in standby during remove and there is no > need to configure sensor registers for stream stop. > > Signed-off-by: Sowjanya Komatineni > --- > drivers/media/i2c/imx274.c | 3 --- > 1 file changed, 3 de

[PATCH v6 2/3] media: i2c: imx274: Remove stop stream i2c writes during remove

2020-09-21 Thread Sowjanya Komatineni
Sensor should already be in standby during remove and there is no need to configure sensor registers for stream stop. Signed-off-by: Sowjanya Komatineni --- drivers/media/i2c/imx274.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c in