Re: [PATCH v6 2/4] net: phy: Add 5GBASER interface mode

On Thu, Oct 29, 2020 at 03:42:00PM +1000, Pavana Sharma wrote: > Add new mode supported by MV88E6393 family. Hi Pavana I asked you to add kerneldoc for this new value, but you have not added it. Please compile your code with W=1, and you should see the warning. Andrew

[PATCH v6 2/4] net: phy: Add 5GBASER interface mode

Add new mode supported by MV88E6393 family. Signed-off-by: Pavana Sharma --- include/linux/phy.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index 3a09d2bf69ea..9de7c57cfd38 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -107,6

Re: [PATCH v6 2/4] net: phy: Add 5GBASER interface mode

On Thu, 29 Oct 2020 15:42:00 +1000 Pavana Sharma wrote: > Add new mode supported by MV88E6393 family. > This commit message isn't ideal. It infers that the Amethyst is first such device to implement this mode, which is not true. The 5gbase-r mode is supported by various other hardware, for