Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-28 Thread Luis R. Rodriguez
On Fri, Apr 28, 2017 at 12:19:05PM +0900, AKASHI Takahiro wrote: > > > > + ret = _request_firmware(_data, name, , device); > > > > + if (ret && driver_data_param_optional(req_params)) > > > > + ret = driver_data_sync_opt_call_cb(req_params); > > > > + else > > > > +

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-28 Thread Luis R. Rodriguez
On Fri, Apr 28, 2017 at 12:19:05PM +0900, AKASHI Takahiro wrote: > > > > + ret = _request_firmware(_data, name, , device); > > > > + if (ret && driver_data_param_optional(req_params)) > > > > + ret = driver_data_sync_opt_call_cb(req_params); > > > > + else > > > > +

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-27 Thread AKASHI Takahiro
Luis, On Fri, Apr 28, 2017 at 02:51:44AM +0200, Luis R. Rodriguez wrote: > On Thu, Apr 13, 2017 at 06:36:17PM +0900, AKASHI Takahiro wrote: > > On Wed, Mar 29, 2017 at 08:25:11PM -0700, Luis R. Rodriguez wrote: > > > Signed-off-by: Luis R. Rodriguez > > > --- > > >

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-27 Thread AKASHI Takahiro
Luis, On Fri, Apr 28, 2017 at 02:51:44AM +0200, Luis R. Rodriguez wrote: > On Thu, Apr 13, 2017 at 06:36:17PM +0900, AKASHI Takahiro wrote: > > On Wed, Mar 29, 2017 at 08:25:11PM -0700, Luis R. Rodriguez wrote: > > > Signed-off-by: Luis R. Rodriguez > > > --- > > >

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-27 Thread Luis R. Rodriguez
On Thu, Apr 13, 2017 at 06:36:17PM +0900, AKASHI Takahiro wrote: > On Wed, Mar 29, 2017 at 08:25:11PM -0700, Luis R. Rodriguez wrote: > > Signed-off-by: Luis R. Rodriguez > > --- > > Documentation/driver-api/firmware/driver_data.rst | 77 + > >

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-27 Thread Luis R. Rodriguez
On Thu, Apr 13, 2017 at 06:36:17PM +0900, AKASHI Takahiro wrote: > On Wed, Mar 29, 2017 at 08:25:11PM -0700, Luis R. Rodriguez wrote: > > Signed-off-by: Luis R. Rodriguez > > --- > > Documentation/driver-api/firmware/driver_data.rst | 77 + > > Documentation/driver-api/firmware/index.rst

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-27 Thread Luis R. Rodriguez
On Thu, Apr 27, 2017 at 09:09:47AM +0300, Luca Coelho wrote: > On Thu, 2017-04-27 at 05:16 +0200, Luis R. Rodriguez wrote: > > > > +int driver_data_request_sync(const char *name, > > > > +    const struct driver_data_req_params > > > > *req_params, > > > > +

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-27 Thread Luis R. Rodriguez
On Thu, Apr 27, 2017 at 09:09:47AM +0300, Luca Coelho wrote: > On Thu, 2017-04-27 at 05:16 +0200, Luis R. Rodriguez wrote: > > > > +int driver_data_request_sync(const char *name, > > > > +    const struct driver_data_req_params > > > > *req_params, > > > > +

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-27 Thread Luis R. Rodriguez
On Thu, Apr 27, 2017 at 08:44:27AM +0300, Luca Coelho wrote: > On Thu, 2017-04-27 at 05:16 +0200, Luis R. Rodriguez wrote: > > > > @@ -1460,6 +1471,128 @@ void release_firmware(const struct firmware *fw) > > > >   } > > > >   EXPORT_SYMBOL(release_firmware); > > > >   > > > > +static int

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-27 Thread Luis R. Rodriguez
On Thu, Apr 27, 2017 at 08:44:27AM +0300, Luca Coelho wrote: > On Thu, 2017-04-27 at 05:16 +0200, Luis R. Rodriguez wrote: > > > > @@ -1460,6 +1471,128 @@ void release_firmware(const struct firmware *fw) > > > >   } > > > >   EXPORT_SYMBOL(release_firmware); > > > >   > > > > +static int

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-27 Thread Luca Coelho
On Thu, 2017-04-27 at 05:16 +0200, Luis R. Rodriguez wrote: > > > +int driver_data_request_sync(const char *name, > > > +    const struct driver_data_req_params *req_params, > > > +    struct device *device) > > > +{ > > > +   const struct firmware

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-27 Thread Luca Coelho
On Thu, 2017-04-27 at 05:16 +0200, Luis R. Rodriguez wrote: > > > +int driver_data_request_sync(const char *name, > > > +    const struct driver_data_req_params *req_params, > > > +    struct device *device) > > > +{ > > > +   const struct firmware

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-26 Thread Luca Coelho
On Thu, 2017-04-27 at 05:16 +0200, Luis R. Rodriguez wrote: > > > @@ -1460,6 +1471,128 @@ void release_firmware(const struct firmware *fw) > > >   } > > >   EXPORT_SYMBOL(release_firmware); > > >   > > > +static int _driver_data_request_api(struct driver_data_params *params, > > > +   

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-26 Thread Luca Coelho
On Thu, 2017-04-27 at 05:16 +0200, Luis R. Rodriguez wrote: > > > @@ -1460,6 +1471,128 @@ void release_firmware(const struct firmware *fw) > > >   } > > >   EXPORT_SYMBOL(release_firmware); > > >   > > > +static int _driver_data_request_api(struct driver_data_params *params, > > > +   

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-26 Thread Luis R. Rodriguez
On Tue, Apr 11, 2017 at 05:01:51PM +0900, takahiro.aka...@linaro.org wrote: > On Mon, Apr 10, 2017 at 12:42:44PM +, Coelho, Luciano wrote: > > On Wed, 2017-03-29 at 20:25 -0700, Luis R. Rodriguez wrote: > > > +Driver data request parameters > > > +== > > > + > > >

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-26 Thread Luis R. Rodriguez
On Tue, Apr 11, 2017 at 05:01:51PM +0900, takahiro.aka...@linaro.org wrote: > On Mon, Apr 10, 2017 at 12:42:44PM +, Coelho, Luciano wrote: > > On Wed, 2017-03-29 at 20:25 -0700, Luis R. Rodriguez wrote: > > > +Driver data request parameters > > > +== > > > + > > >

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-26 Thread Luis R. Rodriguez
On Mon, Apr 10, 2017 at 12:42:44PM +, Coelho, Luciano wrote: > On Wed, 2017-03-29 at 20:25 -0700, Luis R. Rodriguez wrote: > > The firmware API does not scale well: when new features are added we > > either add a new exported symbol or extend the arguments of existing > > routines. For the

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-26 Thread Luis R. Rodriguez
On Mon, Apr 10, 2017 at 12:42:44PM +, Coelho, Luciano wrote: > On Wed, 2017-03-29 at 20:25 -0700, Luis R. Rodriguez wrote: > > The firmware API does not scale well: when new features are added we > > either add a new exported symbol or extend the arguments of existing > > routines. For the

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-13 Thread AKASHI Takahiro
On Wed, Mar 29, 2017 at 08:25:11PM -0700, Luis R. Rodriguez wrote: > The firmware API does not scale well: when new features are added we > either add a new exported symbol or extend the arguments of existing > routines. For the later case this means we need to traverse the kernel > with a slew of

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-13 Thread AKASHI Takahiro
On Wed, Mar 29, 2017 at 08:25:11PM -0700, Luis R. Rodriguez wrote: > The firmware API does not scale well: when new features are added we > either add a new exported symbol or extend the arguments of existing > routines. For the later case this means we need to traverse the kernel > with a slew of

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-11 Thread takahiro.aka...@linaro.org
On Mon, Apr 10, 2017 at 12:42:44PM +, Coelho, Luciano wrote: > On Wed, 2017-03-29 at 20:25 -0700, Luis R. Rodriguez wrote: > > The firmware API does not scale well: when new features are added we > > either add a new exported symbol or extend the arguments of existing > > routines. For the

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-11 Thread takahiro.aka...@linaro.org
On Mon, Apr 10, 2017 at 12:42:44PM +, Coelho, Luciano wrote: > On Wed, 2017-03-29 at 20:25 -0700, Luis R. Rodriguez wrote: > > The firmware API does not scale well: when new features are added we > > either add a new exported symbol or extend the arguments of existing > > routines. For the

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-10 Thread Coelho, Luciano
On Wed, 2017-03-29 at 20:25 -0700, Luis R. Rodriguez wrote: > The firmware API does not scale well: when new features are added we > either add a new exported symbol or extend the arguments of existing > routines. For the later case this means we need to traverse the kernel > with a slew of

Re: [PATCH v6 2/5] firmware: add extensible driver data API

2017-04-10 Thread Coelho, Luciano
On Wed, 2017-03-29 at 20:25 -0700, Luis R. Rodriguez wrote: > The firmware API does not scale well: when new features are added we > either add a new exported symbol or extend the arguments of existing > routines. For the later case this means we need to traverse the kernel > with a slew of

[PATCH v6 2/5] firmware: add extensible driver data API

2017-03-29 Thread Luis R. Rodriguez
The firmware API does not scale well: when new features are added we either add a new exported symbol or extend the arguments of existing routines. For the later case this means we need to traverse the kernel with a slew of collateral evolutions to adjust old driver users. The firmware API is also

[PATCH v6 2/5] firmware: add extensible driver data API

2017-03-29 Thread Luis R. Rodriguez
The firmware API does not scale well: when new features are added we either add a new exported symbol or extend the arguments of existing routines. For the later case this means we need to traverse the kernel with a slew of collateral evolutions to adjust old driver users. The firmware API is also