Re: [PATCH v6 2/6] init_on_alloc: Optimize static branches

2021-03-18 Thread Vlastimil Babka
On 3/15/21 7:02 PM, Kees Cook wrote: > The state of CONFIG_INIT_ON_ALLOC_DEFAULT_ON (and ...ON_FREE...) did not > change the assembly ordering of the static branches: they were always out > of line. Use the new jump_label macros to check the CONFIG settings to > default to the "expected" state,

Re: [PATCH v6 2/6] init_on_alloc: Optimize static branches

2021-03-15 Thread Kees Cook
On Mon, Mar 15, 2021 at 11:02:25AM -0700, Kees Cook wrote: > diff --git a/mm/slab.h b/mm/slab.h > index 076582f58f68..b0977d525c06 100644 > --- a/mm/slab.h > +++ b/mm/slab.h > @@ -601,7 +601,8 @@ static inline void cache_random_seq_destroy(struct > kmem_cache *cachep) { } > > static inline

[PATCH v6 2/6] init_on_alloc: Optimize static branches

2021-03-15 Thread Kees Cook
The state of CONFIG_INIT_ON_ALLOC_DEFAULT_ON (and ...ON_FREE...) did not change the assembly ordering of the static branches: they were always out of line. Use the new jump_label macros to check the CONFIG settings to default to the "expected" state, which slightly optimizes the resulting assembly