Re: [PATCH v6 2/6] tracing: Rework synthetic event command parsing

2021-01-25 Thread Tom Zanussi
Hi Steve, On Fri, 2021-01-22 at 16:00 -0500, Steven Rostedt wrote: > On Thu, 21 Jan 2021 11:01:05 -0600 > Tom Zanussi wrote: > > > @@ -1208,13 +1173,14 @@ static int __create_synth_event(int argc, > > const char *name, const char **argv) > > * where 'field' = type field_name > > *

Re: [PATCH v6 2/6] tracing: Rework synthetic event command parsing

2021-01-25 Thread Tom Zanussi
On Fri, 2021-01-22 at 22:16 +0900, Masami Hiramatsu wrote: > On Thu, 21 Jan 2021 11:01:05 -0600 > Tom Zanussi wrote: > > > Now that command parsing has been delegated to the create functions > > and we're no longer constrained by argv_split(), we can modify the > > synthetic event command parser

Re: [PATCH v6 2/6] tracing: Rework synthetic event command parsing

2021-01-22 Thread Steven Rostedt
On Thu, 21 Jan 2021 11:01:05 -0600 Tom Zanussi wrote: > @@ -1208,13 +1173,14 @@ static int __create_synth_event(int argc, const char > *name, const char **argv) >* where 'field' = type field_name >*/ > > - if (name[0] == '\0' || argc < 1) { > + mutex_lock(&event_mu

Re: [PATCH v6 2/6] tracing: Rework synthetic event command parsing

2021-01-22 Thread Masami Hiramatsu
On Thu, 21 Jan 2021 11:01:05 -0600 Tom Zanussi wrote: > Now that command parsing has been delegated to the create functions > and we're no longer constrained by argv_split(), we can modify the > synthetic event command parser to better match the higher-level > structure of the synthetic event com

[PATCH v6 2/6] tracing: Rework synthetic event command parsing

2021-01-21 Thread Tom Zanussi
Now that command parsing has been delegated to the create functions and we're no longer constrained by argv_split(), we can modify the synthetic event command parser to better match the higher-level structure of the synthetic event commands, which is basically an event name followed by a set of sem