Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-08-07 Thread Richard Genoud
2013/8/6 Mark Brown : > On Tue, Jul 30, 2013 at 12:32:03PM +0200, Richard Genoud wrote: >> From: Nicolas Ferre >> >> Description of the Asoc machine driver for an at91sam9x5 based board >> with a wm8731 audio DAC. Wm8731 is clocked by a crystal and used as a >> master on the SSC/I2S interface.

Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-08-07 Thread Richard Genoud
2013/8/6 Mark Brown broo...@kernel.org: On Tue, Jul 30, 2013 at 12:32:03PM +0200, Richard Genoud wrote: From: Nicolas Ferre nicolas.fe...@atmel.com Description of the Asoc machine driver for an at91sam9x5 based board with a wm8731 audio DAC. Wm8731 is clocked by a crystal and used as a

Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-08-06 Thread Mark Brown
On Tue, Jul 30, 2013 at 12:32:03PM +0200, Richard Genoud wrote: > From: Nicolas Ferre > > Description of the Asoc machine driver for an at91sam9x5 based board > with a wm8731 audio DAC. Wm8731 is clocked by a crystal and used as a > master on the SSC/I2S interface. Its connections are a

Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-08-06 Thread Mark Brown
On Tue, Jul 30, 2013 at 12:32:03PM +0200, Richard Genoud wrote: From: Nicolas Ferre nicolas.fe...@atmel.com Description of the Asoc machine driver for an at91sam9x5 based board with a wm8731 audio DAC. Wm8731 is clocked by a crystal and used as a master on the SSC/I2S interface. Its

Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-08-01 Thread Mark Brown
On Wed, Jul 31, 2013 at 04:16:28PM -0600, Stephen Warren wrote: > On 07/30/2013 04:58 PM, Mark Brown wrote: > > You seem to be assuming that the strings are a bad thing. I'm not > > sure that this is the case modulo the tooling issues... > I do tend to think that using strings is pretty evil...

Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-08-01 Thread Mark Brown
On Wed, Jul 31, 2013 at 04:16:28PM -0600, Stephen Warren wrote: On 07/30/2013 04:58 PM, Mark Brown wrote: You seem to be assuming that the strings are a bad thing. I'm not sure that this is the case modulo the tooling issues... I do tend to think that using strings is pretty evil...

Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-07-31 Thread Stephen Warren
On 07/30/2013 04:58 PM, Mark Brown wrote: > On Tue, Jul 30, 2013 at 03:29:17PM -0600, Stephen Warren wrote: >> On 07/30/2013 02:45 PM, Mark Brown wrote: > >>> You really shouldn't do this, it's not accomplishing much. > >> What it accomplishes is not polluting the CODEC's binding with a >> set

Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-07-31 Thread Stephen Warren
On 07/30/2013 04:58 PM, Mark Brown wrote: On Tue, Jul 30, 2013 at 03:29:17PM -0600, Stephen Warren wrote: On 07/30/2013 02:45 PM, Mark Brown wrote: You really shouldn't do this, it's not accomplishing much. What it accomplishes is not polluting the CODEC's binding with a set of strings

Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-07-30 Thread Mark Brown
On Tue, Jul 30, 2013 at 03:29:17PM -0600, Stephen Warren wrote: > On 07/30/2013 02:45 PM, Mark Brown wrote: > > You really shouldn't do this, it's not accomplishing much. > What it accomplishes is not polluting the CODEC's binding with a set > of strings that must always be supported since DT is

Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-07-30 Thread Stephen Warren
On 07/30/2013 02:45 PM, Mark Brown wrote: > On Tue, Jul 30, 2013 at 11:45:12AM -0600, Stephen Warren wrote: >> On 07/30/2013 04:32 AM, Richard Genoud wrote: > >>> +wm8731 pins: +cf >>> Documentation/devicetree/bindings/sound/wm8731.txt > >> In the Tegra bindings, I deliberately put the list of

Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-07-30 Thread Mark Brown
On Tue, Jul 30, 2013 at 11:45:12AM -0600, Stephen Warren wrote: > On 07/30/2013 04:32 AM, Richard Genoud wrote: > > +wm8731 pins: > > +cf Documentation/devicetree/bindings/sound/wm8731.txt > In the Tegra bindings, I deliberately put the list of CODEC pins into > the audio complex binding rather

Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-07-30 Thread Stephen Warren
On 07/30/2013 04:32 AM, Richard Genoud wrote: > From: Nicolas Ferre > > Description of the Asoc machine driver for an at91sam9x5 based board > with a wm8731 audio DAC. Wm8731 is clocked by a crystal and used as a > master on the SSC/I2S interface. Its connections are a headphone jack > and an

[PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-07-30 Thread Richard Genoud
From: Nicolas Ferre Description of the Asoc machine driver for an at91sam9x5 based board with a wm8731 audio DAC. Wm8731 is clocked by a crystal and used as a master on the SSC/I2S interface. Its connections are a headphone jack and an Line input jack. [Richard: this is based on an old patch

[PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-07-30 Thread Richard Genoud
From: Nicolas Ferre Description of the Asoc machine driver for an at91sam9x5 based board with a wm8731 audio DAC. Wm8731 is clocked by a crystal and used as a master on the SSC/I2S interface. Its connections are a headphone jack and an Line input jack. [Richard: this is based on an old patch

[PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-07-30 Thread Richard Genoud
From: Nicolas Ferre nicolas.fe...@atmel.com Description of the Asoc machine driver for an at91sam9x5 based board with a wm8731 audio DAC. Wm8731 is clocked by a crystal and used as a master on the SSC/I2S interface. Its connections are a headphone jack and an Line input jack. [Richard: this is

[PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-07-30 Thread Richard Genoud
From: Nicolas Ferre nicolas.fe...@atmel.com Description of the Asoc machine driver for an at91sam9x5 based board with a wm8731 audio DAC. Wm8731 is clocked by a crystal and used as a master on the SSC/I2S interface. Its connections are a headphone jack and an Line input jack. [Richard: this is

Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-07-30 Thread Stephen Warren
On 07/30/2013 04:32 AM, Richard Genoud wrote: From: Nicolas Ferre nicolas.fe...@atmel.com Description of the Asoc machine driver for an at91sam9x5 based board with a wm8731 audio DAC. Wm8731 is clocked by a crystal and used as a master on the SSC/I2S interface. Its connections are a

Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-07-30 Thread Mark Brown
On Tue, Jul 30, 2013 at 11:45:12AM -0600, Stephen Warren wrote: On 07/30/2013 04:32 AM, Richard Genoud wrote: +wm8731 pins: +cf Documentation/devicetree/bindings/sound/wm8731.txt In the Tegra bindings, I deliberately put the list of CODEC pins into the audio complex binding rather than

Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-07-30 Thread Stephen Warren
On 07/30/2013 02:45 PM, Mark Brown wrote: On Tue, Jul 30, 2013 at 11:45:12AM -0600, Stephen Warren wrote: On 07/30/2013 04:32 AM, Richard Genoud wrote: +wm8731 pins: +cf Documentation/devicetree/bindings/sound/wm8731.txt In the Tegra bindings, I deliberately put the list of CODEC pins

Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731 boards

2013-07-30 Thread Mark Brown
On Tue, Jul 30, 2013 at 03:29:17PM -0600, Stephen Warren wrote: On 07/30/2013 02:45 PM, Mark Brown wrote: You really shouldn't do this, it's not accomplishing much. What it accomplishes is not polluting the CODEC's binding with a set of strings that must always be supported since DT is an