Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2021-01-18 Thread Mark Brown
On Sat, Jan 16, 2021 at 08:03:25AM +, Timon Baetz wrote: > I could use extcon_get_extcon_dev("max8997-muic") and basically hard > code the extcon device name in the charger driver. Then I only need > charger-supply in DTS which could be added to the parent device's node. > Would that be

Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2021-01-16 Thread Timon Baetz
On Fri, 15 Jan 2021 13:42:14 +, Mark Brown wrote: > On Fri, Jan 15, 2021 at 06:19:28AM +, Timon Baetz wrote: > > On Fri, 8 Jan 2021 16:16:53 +, Mark Brown wrote: > > > On Fri, Jan 08, 2021 at 03:16:48PM +, Timon Baetz wrote: > > > > > Muic needs a node to be used with

Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2021-01-15 Thread Mark Brown
On Fri, Jan 15, 2021 at 06:19:28AM +, Timon Baetz wrote: > On Fri, 8 Jan 2021 16:16:53 +, Mark Brown wrote: > > On Fri, Jan 08, 2021 at 03:16:48PM +, Timon Baetz wrote: > > > Muic needs a node to be used with extcon_get_edev_by_phandle(). > > > Charger needs a node to reference a

Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2021-01-14 Thread Timon Baetz
On Fri, 8 Jan 2021 16:16:53 +, Mark Brown wrote: > On Fri, Jan 08, 2021 at 03:16:48PM +, Timon Baetz wrote: > > > Muic needs a node to be used with extcon_get_edev_by_phandle(). > > Charger needs a node to reference a regulator. > > The pattern is to use the parent device's node. So

Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2021-01-11 Thread Rob Herring
On Wed, Dec 30, 2020 at 08:52:07PM +, Timon Baetz wrote: > Add maxim,max8997-battery and maxim,max8997-muic optional nodes. > > Signed-off-by: Timon Baetz > Acked-by: Krzysztof Kozlowski > --- > v6: No change. > v5: No change. > v4: Make extcon and charger-supply optional. > v3: Reorder

Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2021-01-08 Thread Mark Brown
On Fri, Jan 08, 2021 at 03:16:48PM +, Timon Baetz wrote: > Muic needs a node to be used with extcon_get_edev_by_phandle(). > Charger needs a node to reference a regulator. The pattern is to use the parent device's node. signature.asc Description: PGP signature

Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2021-01-08 Thread Timon Baetz
On Wed, 6 Jan 2021 14:59:31 +, Mark Brown wrote: > On Tue, Jan 05, 2021 at 05:55:29PM +0100, Krzysztof Kozlowski wrote: > > On Mon, Jan 04, 2021 at 09:24:49PM +, Mark Brown wrote: > > > > I'm not sure I follow, sorry? Either the core driver can parse the > > > bindings enough to know

Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2021-01-06 Thread Mark Brown
On Tue, Jan 05, 2021 at 05:55:29PM +0100, Krzysztof Kozlowski wrote: > On Mon, Jan 04, 2021 at 09:24:49PM +, Mark Brown wrote: > > I'm not sure I follow, sorry? Either the core driver can parse the > > bindings enough to know what children it has or (probably better) it can > > instantiate

Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2021-01-05 Thread Krzysztof Kozlowski
On Mon, Jan 04, 2021 at 09:24:49PM +, Mark Brown wrote: > On Mon, Jan 04, 2021 at 07:38:21PM +0100, Krzysztof Kozlowski wrote: > > On Mon, Jan 04, 2021 at 06:27:34PM +, Mark Brown wrote: > > > > We can indicate the presence of features without adding new compatible > > > strings, that's

Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2021-01-04 Thread Mark Brown
On Mon, Jan 04, 2021 at 07:38:21PM +0100, Krzysztof Kozlowski wrote: > On Mon, Jan 04, 2021 at 06:27:34PM +, Mark Brown wrote: > > We can indicate the presence of features without adding new compatible > > strings, that's just encoding the way Linux currently divides things up > > into the

Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2021-01-04 Thread Krzysztof Kozlowski
On Mon, Jan 04, 2021 at 06:27:34PM +, Mark Brown wrote: > On Mon, Jan 04, 2021 at 07:18:25PM +0100, Krzysztof Kozlowski wrote: > > On Mon, Jan 04, 2021 at 01:51:56PM +, Mark Brown wrote: > > > > > +- charger: Node for configuring the charger driver. > > > > + Required properties: > > > >

Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2021-01-04 Thread Mark Brown
On Mon, Jan 04, 2021 at 07:18:25PM +0100, Krzysztof Kozlowski wrote: > On Mon, Jan 04, 2021 at 01:51:56PM +, Mark Brown wrote: > > > +- charger: Node for configuring the charger driver. > > > + Required properties: > > > + - compatible: "maxim,max8997-battery" > > > + Optional properties:

Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2021-01-04 Thread Krzysztof Kozlowski
On Mon, Jan 04, 2021 at 01:51:56PM +, Mark Brown wrote: > On Wed, Dec 30, 2020 at 08:52:07PM +, Timon Baetz wrote: > > > +- charger: Node for configuring the charger driver. > > + Required properties: > > + - compatible: "maxim,max8997-battery" > > + Optional properties: > > + -

Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2021-01-04 Thread Mark Brown
On Wed, Dec 30, 2020 at 08:52:07PM +, Timon Baetz wrote: > +- charger: Node for configuring the charger driver. > + Required properties: > + - compatible: "maxim,max8997-battery" > + Optional properties: > + - extcon: extcon specifier for charging events > + - charger-supply: regulator

[PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes

2020-12-30 Thread Timon Baetz
Add maxim,max8997-battery and maxim,max8997-muic optional nodes. Signed-off-by: Timon Baetz Acked-by: Krzysztof Kozlowski --- v6: No change. v5: No change. v4: Make extcon and charger-supply optional. v3: Reorder patch, no change. v2: Add patch. .../bindings/regulator/max8997-regulator.txt