Re: [PATCH v6 21/21] perf-probe: Add array argument support

2018-03-25 Thread Masami Hiramatsu
On Thu, 22 Mar 2018 16:19:46 +0530 Ravi Bangoria wrote: > Hi Masami :) > > On 03/22/2018 03:53 PM, Masami Hiramatsu wrote: > > On Mon, 19 Mar 2018 13:29:59 +0530 > > Ravi Bangoria wrote: > > > >> > >> Is it okay to allow user to specify array size with type field? > > Fro this patch, yes. > >

Re: [PATCH v6 21/21] perf-probe: Add array argument support

2018-03-22 Thread Ravi Bangoria
Hi Masami :) On 03/22/2018 03:53 PM, Masami Hiramatsu wrote: > On Mon, 19 Mar 2018 13:29:59 +0530 > Ravi Bangoria wrote: > >> >> Is it okay to allow user to specify array size with type field? > Fro this patch, yes. So IIUC, perf _tool_ will allow user to record array either with "name[range]" o

Re: [PATCH v6 21/21] perf-probe: Add array argument support

2018-03-22 Thread Masami Hiramatsu
On Mon, 19 Mar 2018 13:29:59 +0530 Ravi Bangoria wrote: > Hi Masami, > > On 03/17/2018 06:23 PM, Masami Hiramatsu wrote: > > Since kprobes events support an array argument, perf-probe > > can also support dumping array now. > > The syntax are > > > > [] > > or > > [] > > > > where the is ...

Re: [PATCH v6 21/21] perf-probe: Add array argument support

2018-03-19 Thread Ravi Bangoria
Hi Masami, On 03/17/2018 06:23 PM, Masami Hiramatsu wrote: > Since kprobes events support an array argument, perf-probe > can also support dumping array now. > The syntax are > > [] > or > [] > > where the is ... e.g. array[0..5]. > This can also be available with string type. In this > case, t

[PATCH v6 21/21] perf-probe: Add array argument support

2018-03-17 Thread Masami Hiramatsu
Since kprobes events support an array argument, perf-probe can also support dumping array now. The syntax are [] or [] where the is ... e.g. array[0..5]. This can also be available with string type. In this case, the string array should be "char *array[]" or "char **array_ptr". Note that this