Re: [PATCH v6 25/35] i2c: tegra: Factor out error recovery from tegra_i2c_xfer_msg()

2020-09-08 Thread Dmitry Osipenko
08.09.2020 11:49, Andy Shevchenko пишет: > On Tue, Sep 8, 2020 at 5:11 AM Dmitry Osipenko wrote: >> >> Factor out error recovery code from tegra_i2c_xfer_msg() in order to >> make this function easier to read and follow. > > Ordering issue. > You have a patch that replaces int -> unsigned int or

Re: [PATCH v6 25/35] i2c: tegra: Factor out error recovery from tegra_i2c_xfer_msg()

2020-09-08 Thread Andy Shevchenko
On Tue, Sep 8, 2020 at 5:11 AM Dmitry Osipenko wrote: > > Factor out error recovery code from tegra_i2c_xfer_msg() in order to > make this function easier to read and follow. Ordering issue. You have a patch that replaces int -> unsigned int or so, which obviously has less impact (severity) than

[PATCH v6 25/35] i2c: tegra: Factor out error recovery from tegra_i2c_xfer_msg()

2020-09-07 Thread Dmitry Osipenko
Factor out error recovery code from tegra_i2c_xfer_msg() in order to make this function easier to read and follow. Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 46 ++ 1 file changed, 30 insertions(+), 16