Re: [PATCH v6 28/57] pcie-gadget-spear: Remove dev_err() usage after platform_get_irq()

2019-08-05 Thread Greg Kroah-Hartman
On Wed, Jul 31, 2019 at 07:16:22AM -0700, Stephen Boyd wrote: > Quoting Arnd Bergmann (2019-07-30 11:29:45) > > On Tue, Jul 30, 2019 at 8:16 PM Stephen Boyd wrote: > > > > > > We don't need dev_err() messages when platform_get_irq() fails now that > > > platform_get_irq() prints an error message

Re: [PATCH v6 28/57] pcie-gadget-spear: Remove dev_err() usage after platform_get_irq()

2019-07-31 Thread Stephen Boyd
Quoting Arnd Bergmann (2019-07-30 11:29:45) > On Tue, Jul 30, 2019 at 8:16 PM Stephen Boyd wrote: > > > > We don't need dev_err() messages when platform_get_irq() fails now that > > platform_get_irq() prints an error message itself when something goes > > wrong. Let's remove these prints with a

Re: [PATCH v6 28/57] pcie-gadget-spear: Remove dev_err() usage after platform_get_irq()

2019-07-30 Thread Arnd Bergmann
On Tue, Jul 30, 2019 at 8:16 PM Stephen Boyd wrote: > > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch. > Cc: Arnd Bergmann > Cc: Greg

[PATCH v6 28/57] pcie-gadget-spear: Remove dev_err() usage after platform_get_irq()

2019-07-30 Thread Stephen Boyd
We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) |