Re: [PATCH v6 3/3] arm64: dts: allwinner: a64: enable sound on Pinebook

2018-11-17 Thread Vasily Khoruzhick
On Sat, Nov 17, 2018 at 8:02 AM Chen-Yu Tsai wrote: > > On Thu, Nov 15, 2018 at 1:48 PM Vasily Khoruzhick wrote: > > > > On Wed, Nov 7, 2018 at 11:30 PM Chen-Yu Tsai wrote: > > > > + > > > > + speaker_amp: speaker_amp { > > > > + compatible = "simple-audio-amplifier"; > > > >

Re: [PATCH v6 3/3] arm64: dts: allwinner: a64: enable sound on Pinebook

2018-11-17 Thread Chen-Yu Tsai
On Thu, Nov 15, 2018 at 1:48 PM Vasily Khoruzhick wrote: > > On Wed, Nov 7, 2018 at 11:30 PM Chen-Yu Tsai wrote: > > > + > > > + speaker_amp: speaker_amp { > > > + compatible = "simple-audio-amplifier"; > > > + enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 *

Re: [PATCH v6 3/3] arm64: dts: allwinner: a64: enable sound on Pinebook

2018-11-14 Thread Vasily Khoruzhick
On Wed, Nov 7, 2018 at 11:30 PM Chen-Yu Tsai wrote: > > + > > + speaker_amp: speaker_amp { > > + compatible = "simple-audio-amplifier"; > > + enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */ > > You might want to add a sound-name-prefix property. See > >

Re: [PATCH v6 3/3] arm64: dts: allwinner: a64: enable sound on Pinebook

2018-11-08 Thread Vasily Khoruzhick
On Wed, Nov 7, 2018 at 11:30 PM Chen-Yu Tsai wrote: > > On Thu, Nov 8, 2018 at 2:42 PM Vasily Khoruzhick wrote: > > > > This commit enables I2S, digital and analog parts of audiocodec on > > Pinebook > > > > Signed-off-by: Vasily Khoruzhick > > --- > > .../dts/allwinner/sun50i-a64-pinebook.dts

Re: [PATCH v6 3/3] arm64: dts: allwinner: a64: enable sound on Pinebook

2018-11-07 Thread Chen-Yu Tsai
On Thu, Nov 8, 2018 at 2:42 PM Vasily Khoruzhick wrote: > > This commit enables I2S, digital and analog parts of audiocodec on > Pinebook > > Signed-off-by: Vasily Khoruzhick > --- > .../dts/allwinner/sun50i-a64-pinebook.dts | 42 +++ > 1 file changed, 42 insertions(+) > > di

[PATCH v6 3/3] arm64: dts: allwinner: a64: enable sound on Pinebook

2018-11-07 Thread Vasily Khoruzhick
This commit enables I2S, digital and analog parts of audiocodec on Pinebook Signed-off-by: Vasily Khoruzhick --- .../dts/allwinner/sun50i-a64-pinebook.dts | 42 +++ 1 file changed, 42 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts b/arch/ar