Re: [PATCH v6 3/4] block: implement runtime pm strategy

2013-01-14 Thread Alan Stern
On Mon, 14 Jan 2013, Aaron Lu wrote: > On Tue, Jan 08, 2013 at 10:22:45AM -0500, Alan Stern wrote: > > Just as importantly, all of the public routines added in patch 2/4 to > > blk-core.c should have kerneldoc explaining how and where to use them. > > In particular, the kerneldoc for

Re: [PATCH v6 3/4] block: implement runtime pm strategy

2013-01-14 Thread Alan Stern
On Mon, 14 Jan 2013, Aaron Lu wrote: On Tue, Jan 08, 2013 at 10:22:45AM -0500, Alan Stern wrote: Just as importantly, all of the public routines added in patch 2/4 to blk-core.c should have kerneldoc explaining how and where to use them. In particular, the kerneldoc for

Re: [PATCH v6 3/4] block: implement runtime pm strategy

2013-01-13 Thread Aaron Lu
On Tue, Jan 08, 2013 at 10:22:45AM -0500, Alan Stern wrote: > Just as importantly, all of the public routines added in patch 2/4 to > blk-core.c should have kerneldoc explaining how and where to use them. > In particular, the kerneldoc for blk_pm_runtime_init() has to mention > that the block

Re: [PATCH v6 3/4] block: implement runtime pm strategy

2013-01-13 Thread Aaron Lu
On Tue, Jan 08, 2013 at 10:22:45AM -0500, Alan Stern wrote: Just as importantly, all of the public routines added in patch 2/4 to blk-core.c should have kerneldoc explaining how and where to use them. In particular, the kerneldoc for blk_pm_runtime_init() has to mention that the block

Re: [PATCH v6 3/4] block: implement runtime pm strategy

2013-01-08 Thread Alan Stern
On Tue, 8 Jan 2013, Aaron Lu wrote: > >> --- a/include/linux/blkdev.h > >> +++ b/include/linux/blkdev.h > >> @@ -974,6 +974,40 @@ extern int blk_pre_runtime_suspend(struct > >> request_queue *q); > >> extern void blk_post_runtime_suspend(struct request_queue *q, int err); > >> extern void

Re: [PATCH v6 3/4] block: implement runtime pm strategy

2013-01-08 Thread Alan Stern
On Tue, 8 Jan 2013, Aaron Lu wrote: --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -974,6 +974,40 @@ extern int blk_pre_runtime_suspend(struct request_queue *q); extern void blk_post_runtime_suspend(struct request_queue *q, int err); extern void

Re: [PATCH v6 3/4] block: implement runtime pm strategy

2013-01-07 Thread Aaron Lu
On 01/08/2013 01:21 AM, Alan Stern wrote: > On Sun, 6 Jan 2013, Aaron Lu wrote: > >> From: Lin Ming >> >> When a request is added: >> If device is suspended or is suspending and the request is not a >> PM request, resume the device. >> >> When the last request finishes: >> Call

Re: [PATCH v6 3/4] block: implement runtime pm strategy

2013-01-07 Thread Alan Stern
On Sun, 6 Jan 2013, Aaron Lu wrote: > From: Lin Ming > > When a request is added: > If device is suspended or is suspending and the request is not a > PM request, resume the device. > > When the last request finishes: > Call pm_runtime_mark_last_busy() and pm_runtime_autosuspend().

Re: [PATCH v6 3/4] block: implement runtime pm strategy

2013-01-07 Thread Alan Stern
On Sun, 6 Jan 2013, Aaron Lu wrote: From: Lin Ming ming.m@intel.com When a request is added: If device is suspended or is suspending and the request is not a PM request, resume the device. When the last request finishes: Call pm_runtime_mark_last_busy() and

Re: [PATCH v6 3/4] block: implement runtime pm strategy

2013-01-07 Thread Aaron Lu
On 01/08/2013 01:21 AM, Alan Stern wrote: On Sun, 6 Jan 2013, Aaron Lu wrote: From: Lin Ming ming.m@intel.com When a request is added: If device is suspended or is suspending and the request is not a PM request, resume the device. When the last request finishes: Call

[PATCH v6 3/4] block: implement runtime pm strategy

2013-01-06 Thread Aaron Lu
From: Lin Ming When a request is added: If device is suspended or is suspending and the request is not a PM request, resume the device. When the last request finishes: Call pm_runtime_mark_last_busy() and pm_runtime_autosuspend(). When pick a request: If device is

[PATCH v6 3/4] block: implement runtime pm strategy

2013-01-06 Thread Aaron Lu
From: Lin Ming ming.m@intel.com When a request is added: If device is suspended or is suspending and the request is not a PM request, resume the device. When the last request finishes: Call pm_runtime_mark_last_busy() and pm_runtime_autosuspend(). When pick a request: If