Re: [PATCH v6 3/4] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-05-11 Thread Jonathan Richardson
Tim, just one comment below. All other suggestions will be made for the next patch set. On 15-05-06 09:26 PM, Tim Kryger wrote: > On Fri, Apr 10, 2015 at 11:58 AM, Jonathan Richardson > wrote: > >> The polarity procedure no longer applies the settings to change the >> output signal because it

Re: [PATCH v6 3/4] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-05-11 Thread Jonathan Richardson
Tim, just one comment below. All other suggestions will be made for the next patch set. On 15-05-06 09:26 PM, Tim Kryger wrote: On Fri, Apr 10, 2015 at 11:58 AM, Jonathan Richardson jonat...@broadcom.com wrote: The polarity procedure no longer applies the settings to change the output

Re: [PATCH v6 3/4] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-05-06 Thread Tim Kryger
On Fri, Apr 10, 2015 at 11:58 AM, Jonathan Richardson wrote: > The polarity procedure no longer applies the settings to change the > output signal because it can't be called when the pwm is enabled anyway. > The polarity is only updated in the control register. The correct > polarity will be

Re: [PATCH v6 3/4] pwm: kona: Fix incorrect config, disable, and polarity procedures

2015-05-06 Thread Tim Kryger
On Fri, Apr 10, 2015 at 11:58 AM, Jonathan Richardson jonat...@broadcom.com wrote: The polarity procedure no longer applies the settings to change the output signal because it can't be called when the pwm is enabled anyway. The polarity is only updated in the control register. The correct