Re: [PATCH v6 3/5] counter: Add character device interface

2021-01-21 Thread Jonathan Cameron
On Thu, 21 Jan 2021 17:03:11 +0900 William Breathitt Gray wrote: > On Tue, Jan 19, 2021 at 10:20:22AM +0100, Oleksij Rempel wrote: > > On Sun, Nov 22, 2020 at 03:29:54PM -0500, William Breathitt Gray wrote: > > > This patch introduces a character device interface for the Counter > > > subsystem

Re: [PATCH v6 3/5] counter: Add character device interface

2021-01-21 Thread William Breathitt Gray
On Tue, Jan 19, 2021 at 10:20:22AM +0100, Oleksij Rempel wrote: > On Sun, Nov 22, 2020 at 03:29:54PM -0500, William Breathitt Gray wrote: > > This patch introduces a character device interface for the Counter > > subsystem. Device data is exposed through standard character device read > > operation

Re: [PATCH v6 3/5] counter: Add character device interface

2021-01-19 Thread Oleksij Rempel
On Sun, Nov 22, 2020 at 03:29:54PM -0500, William Breathitt Gray wrote: > This patch introduces a character device interface for the Counter > subsystem. Device data is exposed through standard character device read > operations. Device data is gathered when a Counter event is pushed by > the respe

Re: [PATCH v6 3/5] counter: Add character device interface

2020-12-25 Thread William Breathitt Gray
Hi David, I agree with your suggested changes -- just a couple select comments following below. On Sun, Dec 13, 2020 at 05:58:26PM -0600, David Lechner wrote: > > +static int counter_add_watch(struct counter_device *const counter, > > +const unsigned long arg) > > +{ [...

Re: [PATCH v6 3/5] counter: Add character device interface

2020-12-13 Thread David Lechner
On 11/22/20 2:29 PM, William Breathitt Gray wrote: This patch introduces a character device interface for the Counter subsystem. Device data is exposed through standard character device read operations. Device data is gathered when a Counter event is pushed by the respective Counter device driver

[PATCH v6 3/5] counter: Add character device interface

2020-11-22 Thread William Breathitt Gray
This patch introduces a character device interface for the Counter subsystem. Device data is exposed through standard character device read operations. Device data is gathered when a Counter event is pushed by the respective Counter device driver. Configuration is handled via ioctl operations on th