Re: [PATCH v6 3/5] misc: fastrpc: Add support for context Invoke method

2019-02-08 Thread Srinivas Kandagatla
On 08/02/2019 14:11, Greg KH wrote: On 08/02/2019 13:55, Greg KH wrote: + + /* Make sure reserved field is set to 0 */ + if (args->reserved) { + kfree(args); + return -EINVAL; Am I wrong in that you are only checking the

Re: [PATCH v6 3/5] misc: fastrpc: Add support for context Invoke method

2019-02-08 Thread Greg KH
On Fri, Feb 08, 2019 at 02:01:33PM +, Srinivas Kandagatla wrote: > Thanks for the review, > > On 08/02/2019 13:55, Greg KH wrote: > > > + > > > + /* Make sure reserved field is set to 0 */ > > > + if (args->reserved) { > > > + kfree(args); > > > +

Re: [PATCH v6 3/5] misc: fastrpc: Add support for context Invoke method

2019-02-08 Thread Srinivas Kandagatla
Thanks for the review, On 08/02/2019 13:55, Greg KH wrote: + + /* Make sure reserved field is set to 0 */ + if (args->reserved) { + kfree(args); + return -EINVAL; Am I wrong in that you are only checking the first reserved

Re: [PATCH v6 3/5] misc: fastrpc: Add support for context Invoke method

2019-02-08 Thread Greg KH
On Fri, Feb 08, 2019 at 01:23:04PM +, Srinivas Kandagatla wrote: > +static int fastrpc_invoke(struct fastrpc_user *fl, char __user *argp) > +{ > + struct fastrpc_invoke_args *args = NULL; > + struct fastrpc_invoke inv; > + u32 nscalars; > + int err; > + > + if (copy_from_use

[PATCH v6 3/5] misc: fastrpc: Add support for context Invoke method

2019-02-08 Thread Srinivas Kandagatla
This patch adds support to compute context invoke method on the remote processor (DSP). This involves setting up the functions input and output arguments, input and output handles and mapping the dmabuf fd for the argument/handle buffers. The below diagram depicts invocation of a single method whe