Re: [PATCH v6 3/6] tracing: Update synth command errors

On Fri, 2021-01-22 at 22:23 +0900, Masami Hiramatsu wrote: > Hi Tom, > > On Thu, 21 Jan 2021 11:01:06 -0600 > Tom Zanussi wrote: > > > Since array types are handled differently, errors referencing them > > also need to be handled differently. Add and use a new > > INVALID_ARRAY_SPEC error. Als

Re: [PATCH v6 3/6] tracing: Update synth command errors

On Thu, 21 Jan 2021 11:01:06 -0600 Tom Zanussi wrote: > +static int check_command(const char *raw_command) > +{ > + char **argv = NULL, *cmd, *saved_cmd, *name_and_field; > + int argc, ret = 0; > + > + cmd = saved_cmd = kstrdup(raw_command, GFP_KERNEL); > + if (!cmd) > +

Re: [PATCH v6 3/6] tracing: Update synth command errors

Hi Tom, On Thu, 21 Jan 2021 11:01:06 -0600 Tom Zanussi wrote: > Since array types are handled differently, errors referencing them > also need to be handled differently. Add and use a new > INVALID_ARRAY_SPEC error. Also add INVALID_CMD and INVALID_DYN_CMD to > catch and display the correct fo

[PATCH v6 3/6] tracing: Update synth command errors

Since array types are handled differently, errors referencing them also need to be handled differently. Add and use a new INVALID_ARRAY_SPEC error. Also add INVALID_CMD and INVALID_DYN_CMD to catch and display the correct form for badly-formed commands, which can also be used in place of CMD_INCO