Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-11 Thread Felipe Balbi
Hi, On Thu, Sep 11, 2014 at 09:10:21PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 10 September 2014 01:26 PM, Vivek Gautam wrote: > > On Wed, Sep 10, 2014 at 10:53 AM, Vivek Gautam > > wrote: > >> On Wed, Sep 10, 2014 at 10:23 AM, Felipe Balbi wrote: > >>> On Wed, Sep 10, 2014

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-11 Thread Kishon Vijay Abraham I
Hi, On Wednesday 10 September 2014 01:26 PM, Vivek Gautam wrote: > On Wed, Sep 10, 2014 at 10:53 AM, Vivek Gautam > wrote: >> On Wed, Sep 10, 2014 at 10:23 AM, Felipe Balbi wrote: >>> On Wed, Sep 10, 2014 at 09:09:57AM +0530, Vivek Gautam wrote: On Wed, Sep 10, 2014 at 9:07 AM, Vivek Gauta

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-10 Thread Vivek Gautam
Hi, On Thursday, September 11, 2014 1:52 AM, "Julius Werner" wrote right, use that to call phy_init() at the right time, then you need to add a new ->calibrate() method which, likely, will only be used by you ;-) so you mean, the xhci should itself call phy_init() at a time suitable, s

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-10 Thread Julius Werner
>> right, use that to call phy_init() at the right time, then you need to >> add a new ->calibrate() method which, likely, will only be used by you >> ;-) > so you mean, the xhci should itself call phy_init() at a time suitable, > so that ->calibrate() is not required at all ? I'm not sure if tha

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-10 Thread Vivek Gautam
On Wed, Sep 10, 2014 at 10:53 AM, Vivek Gautam wrote: > On Wed, Sep 10, 2014 at 10:23 AM, Felipe Balbi wrote: >> On Wed, Sep 10, 2014 at 09:09:57AM +0530, Vivek Gautam wrote: >>> On Wed, Sep 10, 2014 at 9:07 AM, Vivek Gautam >>> wrote: >>> > adding Julius here, >>> >>> i think i had missed addi

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-09 Thread Vivek Gautam
On Wed, Sep 10, 2014 at 10:23 AM, Felipe Balbi wrote: > On Wed, Sep 10, 2014 at 09:09:57AM +0530, Vivek Gautam wrote: >> On Wed, Sep 10, 2014 at 9:07 AM, Vivek Gautam >> wrote: >> > adding Julius here, >> >> i think i had missed adding Julius for this entire series :-( >> I should be more carefu

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-09 Thread Felipe Balbi
On Wed, Sep 10, 2014 at 09:09:57AM +0530, Vivek Gautam wrote: > On Wed, Sep 10, 2014 at 9:07 AM, Vivek Gautam > wrote: > > adding Julius here, > > i think i had missed adding Julius for this entire series :-( > I should be more careful with the CC list in future. > Added his chromium id, since t

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-09 Thread Vivek Gautam
On Wed, Sep 10, 2014 at 9:07 AM, Vivek Gautam wrote: > adding Julius here, i think i had missed adding Julius for this entire series :-( I should be more careful with the CC list in future. Added his chromium id, since that seems to be more active. > > > On Tue, Sep 9, 2014 at 8:12 PM, Felipe Ba

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-09 Thread Vivek Gautam
adding Julius here, On Tue, Sep 9, 2014 at 8:12 PM, Felipe Balbi wrote: > On Tue, Sep 09, 2014 at 07:19:50AM +0530, Vivek Gautam wrote: >> Hi, >> >> >> On Mon, Sep 8, 2014 at 7:14 PM, Felipe Balbi wrote: >> > Hi, >> > >> > On Mon, Sep 08, 2014 at 09:53:09AM +0530, Vivek Gautam wrote: >> >> On F

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-09 Thread Felipe Balbi
On Tue, Sep 09, 2014 at 07:19:50AM +0530, Vivek Gautam wrote: > Hi, > > > On Mon, Sep 8, 2014 at 7:14 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Sep 08, 2014 at 09:53:09AM +0530, Vivek Gautam wrote: > >> On Fri, Sep 5, 2014 at 11:26 PM, Felipe Balbi wrote: > >> > On Thu, Sep 04, 2014 at 12

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-08 Thread Vivek Gautam
Hi, On Mon, Sep 8, 2014 at 7:14 PM, Felipe Balbi wrote: > Hi, > > On Mon, Sep 08, 2014 at 09:53:09AM +0530, Vivek Gautam wrote: >> On Fri, Sep 5, 2014 at 11:26 PM, Felipe Balbi wrote: >> > On Thu, Sep 04, 2014 at 12:01:19PM +0530, Vivek Gautam wrote: >> >> > Don't we have phy_power_on() >> >> >

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-08 Thread Felipe Balbi
Hi, On Mon, Sep 08, 2014 at 09:53:09AM +0530, Vivek Gautam wrote: > On Fri, Sep 5, 2014 at 11:26 PM, Felipe Balbi wrote: > > On Thu, Sep 04, 2014 at 12:01:19PM +0530, Vivek Gautam wrote: > >> > Don't we have phy_power_on() > >> > for that ? It looks like you could just as well do this from > >> >

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-07 Thread Vivek Gautam
On Fri, Sep 5, 2014 at 11:26 PM, Felipe Balbi wrote: > On Thu, Sep 04, 2014 at 12:01:19PM +0530, Vivek Gautam wrote: >> > Don't we have phy_power_on() >> > for that ? It looks like you could just as well do this from >> > phy_power_on() ? >> >> No, unfortunately keeping these calibration settings

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-05 Thread Felipe Balbi
On Thu, Sep 04, 2014 at 12:01:19PM +0530, Vivek Gautam wrote: > > Don't we have phy_power_on() > > for that ? It looks like you could just as well do this from > > phy_power_on() ? > > No, unfortunately keeping these calibration settings in phy_power_on() > doesn't help, since we need to do this a

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-03 Thread Vivek Gautam
On Wed, Sep 3, 2014 at 8:12 PM, Felipe Balbi wrote: > Hi, > > On Wed, Sep 03, 2014 at 12:59:27PM +0530, Vivek Gautam wrote: >> > On Tue, Sep 02, 2014 at 04:42:18PM +0530, Vivek Gautam wrote: >> >> Adding phy calibrate callback, which facilitates setting certain >> >> PHY settings post initializati

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-03 Thread Felipe Balbi
Hi, On Wed, Sep 03, 2014 at 12:59:27PM +0530, Vivek Gautam wrote: > > On Tue, Sep 02, 2014 at 04:42:18PM +0530, Vivek Gautam wrote: > >> Adding phy calibrate callback, which facilitates setting certain > >> PHY settings post initialization of the PHY controller. > >> Exynos5420 and Exynos5800 have

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-03 Thread Vivek Gautam
Hi Felipe, On Tue, Sep 2, 2014 at 8:04 PM, Felipe Balbi wrote: > Hi, > > On Tue, Sep 02, 2014 at 04:42:18PM +0530, Vivek Gautam wrote: >> Adding phy calibrate callback, which facilitates setting certain >> PHY settings post initialization of the PHY controller. >> Exynos5420 and Exynos5800 have

Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-02 Thread Felipe Balbi
Hi, On Tue, Sep 02, 2014 at 04:42:18PM +0530, Vivek Gautam wrote: > Adding phy calibrate callback, which facilitates setting certain > PHY settings post initialization of the PHY controller. > Exynos5420 and Exynos5800 have 28nm USB 3.0 DRD PHY for which > the Loss-of-Signal (LOS) Detector Thresho

[PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-09-02 Thread Vivek Gautam
Adding phy calibrate callback, which facilitates setting certain PHY settings post initialization of the PHY controller. Exynos5420 and Exynos5800 have 28nm USB 3.0 DRD PHY for which the Loss-of-Signal (LOS) Detector Threshold Level as well as Tx-Vboost-Level should be controlled for Super-Speed op