Re: [PATCH v6 4/4] pinctrl: qcom: Don't clear pending interrupts when enabling

2021-01-14 Thread Stephen Boyd
Quoting Douglas Anderson (2021-01-14 15:40:27) > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c > b/drivers/pinctrl/qcom/pinctrl-msm.c > index 192ed31eabf4..712a693425fc 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -1097,16 +1128,11 @@ static i

[PATCH v6 4/4] pinctrl: qcom: Don't clear pending interrupts when enabling

2021-01-14 Thread Douglas Anderson
In Linux, if a driver does disable_irq() and later does enable_irq() on its interrupt, I believe it's expecting these properties: * If an interrupt was pending when the driver disabled then it will still be pending after the driver re-enables. * If an edge-triggered interrupt comes in while an in