Re: [PATCH v6 4/4] tracing: Histogram for delayed hrtimer offsets

2016-09-23 Thread Carsten Emde
On 09/09/2016 03:30 PM, Thomas Gleixner wrote: > On Thu, 8 Sep 2016, Binoy Jayan wrote: >> On 8 September 2016 at 12:40, Thomas Gleixner wrote: > [..] + latency = ktime_to_ns(ktime_sub(basenow, + ktime_to_ns(timer->praecox) ? +

Re: [PATCH v6 4/4] tracing: Histogram for delayed hrtimer offsets

2016-09-09 Thread Thomas Gleixner
On Fri, 9 Sep 2016, Mark Brown wrote: > On Thu, Sep 08, 2016 at 03:09:36PM +0530, Binoy Jayan wrote: > > On 8 September 2016 at 12:40, Thomas Gleixner wrote: > > > On Wed, 7 Sep 2016, Binoy Jayan wrote: > > > >> +#ifdef CONFIG_DELAYED_TIMER_OFFSETS_HIST > > >> + ktime_t

Re: [PATCH v6 4/4] tracing: Histogram for delayed hrtimer offsets

2016-09-09 Thread Mark Brown
On Thu, Sep 08, 2016 at 03:09:36PM +0530, Binoy Jayan wrote: > On 8 September 2016 at 12:40, Thomas Gleixner wrote: > > On Wed, 7 Sep 2016, Binoy Jayan wrote: > >> +#ifdef CONFIG_DELAYED_TIMER_OFFSETS_HIST > >> + ktime_t praecox; > >> +#endif > > And of course documen

Re: [PATCH v6 4/4] tracing: Histogram for delayed hrtimer offsets

2016-09-09 Thread Thomas Gleixner
On Thu, 8 Sep 2016, Binoy Jayan wrote: > On 8 September 2016 at 12:40, Thomas Gleixner wrote: > >> +#ifdef CONFIG_DELAYED_TIMER_OFFSETS_HIST > >> + ktime_t praecox; > >> +#endif > > > > And of course documenting new struct members is optional, correct? I'm > > really l

Re: [PATCH v6 4/4] tracing: Histogram for delayed hrtimer offsets

2016-09-08 Thread Binoy Jayan
[Adding Carsten in cc ] Thank you Thomas for reviewing this and providing insights. On 8 September 2016 at 12:40, Thomas Gleixner wrote: > On Wed, 7 Sep 2016, Binoy Jayan wrote: >> diff --git a/include/linux/hrtimer.h b/include/linux/hrtimer.h >> index 5e00f80..9146842 100644 >> --- a/include/li

Re: [PATCH v6 4/4] tracing: Histogram for delayed hrtimer offsets

2016-09-08 Thread Thomas Gleixner
On Wed, 7 Sep 2016, Binoy Jayan wrote: > diff --git a/include/linux/hrtimer.h b/include/linux/hrtimer.h > index 5e00f80..9146842 100644 > --- a/include/linux/hrtimer.h > +++ b/include/linux/hrtimer.h > @@ -104,6 +104,9 @@ struct hrtimer { > struct hrtimer_clock_base *base; > u8

Re: [PATCH v6 4/4] tracing: Histogram for delayed hrtimer offsets

2016-09-07 Thread Masami Hiramatsu
2016-09-07 20:13 GMT+09:00 Binoy Jayan : > Generate a histogram of the latencies of delayed timer offsets in > nanoseconds. It shows the latency captured due to a delayed timer expire > event. It happens for example when a timer misses its deadline due to > disabled interrupts. A process if schedul

[PATCH v6 4/4] tracing: Histogram for delayed hrtimer offsets

2016-09-07 Thread Binoy Jayan
Generate a histogram of the latencies of delayed timer offsets in nanoseconds. It shows the latency captured due to a delayed timer expire event. It happens for example when a timer misses its deadline due to disabled interrupts. A process if scheduled as a result of the timer expiration suffers th