Re: [PATCH v6 4/5] fuse: Ensure posix acls are translated outside of init_user_ns

2018-02-26 Thread Eric W. Biederman
ebied...@xmission.com (Eric W. Biederman) writes: > Miklos Szeredi writes: > >> On Thu, Feb 22, 2018 at 11:50 PM, Eric W. Biederman >> wrote: >> >>> So if we could figure out how to use the generic acl support for the old >>> brand of fuse filesystems that don't set FUSE_POSIX_ACL it would be mu

Re: [PATCH v6 4/5] fuse: Ensure posix acls are translated outside of init_user_ns

2018-02-26 Thread Eric W. Biederman
Miklos Szeredi writes: > On Thu, Feb 22, 2018 at 11:50 PM, Eric W. Biederman > wrote: > >> So if we could figure out how to use the generic acl support for the old >> brand of fuse filesystems that don't set FUSE_POSIX_ACL it would be much >> easier to support them long term. > > Simplest and mo

Re: [PATCH v6 4/5] fuse: Ensure posix acls are translated outside of init_user_ns

2018-02-25 Thread Miklos Szeredi
On Thu, Feb 22, 2018 at 11:50 PM, Eric W. Biederman wrote: > So if we could figure out how to use the generic acl support for the old > brand of fuse filesystems that don't set FUSE_POSIX_ACL it would be much > easier to support them long term. Simplest and most robust way seems to be to do ever

Re: [PATCH v6 4/5] fuse: Ensure posix acls are translated outside of init_user_ns

2018-02-22 Thread Eric W. Biederman
ebied...@xmission.com (Eric W. Biederman) writes: > Miklos Szeredi writes: > >> On Wed, Feb 21, 2018 at 9:29 PM, Eric W. Biederman >> wrote: >>> Ensure the translation happens by failing to read or write >>> posix acls when the filesystem has not indicated it supports >>> posix acls. >> >> For t

Re: [PATCH v6 4/5] fuse: Ensure posix acls are translated outside of init_user_ns

2018-02-22 Thread Eric W. Biederman
Miklos Szeredi writes: > On Wed, Feb 21, 2018 at 9:29 PM, Eric W. Biederman > wrote: >> Ensure the translation happens by failing to read or write >> posix acls when the filesystem has not indicated it supports >> posix acls. > > For the first iteration this is fine, but we could convert the ra

Re: [PATCH v6 4/5] fuse: Ensure posix acls are translated outside of init_user_ns

2018-02-22 Thread Miklos Szeredi
On Wed, Feb 21, 2018 at 9:29 PM, Eric W. Biederman wrote: > Ensure the translation happens by failing to read or write > posix acls when the filesystem has not indicated it supports > posix acls. For the first iteration this is fine, but we could convert the raw xattrs as well, if we later want

[PATCH v6 4/5] fuse: Ensure posix acls are translated outside of init_user_ns

2018-02-21 Thread Eric W. Biederman
Ensure the translation happens by failing to read or write posix acls when the filesystem has not indicated it supports posix acls. This ensures that modern cached posix acl support is available and used when dealing with posix acls. This is important because only that path has the code to conver