Re: [PATCH v6 4/6] media: i2c: Add TDA1997x HDMI receiver driver

2018-01-31 Thread Hans Verkuil
On 02/01/2018 05:47 AM, Tim Harvey wrote: > Hans, > > You forgot to include v4l2-ctl-selection.cpp in your patch. You mean v4l2-ctl-subdev.cpp :-) Anyway, I plan on committing this to v4l2-ctl soon. I'll let you know when that's done. I added support for almost all subdev ioctls to v4l2-ctl. R

Re: [PATCH v6 4/6] media: i2c: Add TDA1997x HDMI receiver driver

2018-01-31 Thread Tim Harvey
Tim Harvey - Principal Software Engineer Gateworks Corporation - http://www.gateworks.com/ 3026 S. Higuera St. San Luis Obispo CA 93401 805-781-2000 On Wed, Jan 31, 2018 at 5:22 AM, Hans Verkuil wrote: > On 01/31/18 08:38, Hans Verkuil wrote: >> On 01/31/2018 05:51 AM, Tim Harvey wrote: >>> On M

Re: [PATCH v6 4/6] media: i2c: Add TDA1997x HDMI receiver driver

2018-01-31 Thread Hans Verkuil
On 01/31/18 08:38, Hans Verkuil wrote: > On 01/31/2018 05:51 AM, Tim Harvey wrote: >> On Mon, Jan 29, 2018 at 4:00 AM, Hans Verkuil wrote: >>> On 01/25/2018 05:15 PM, Tim Harvey wrote: >> > > Hmm. This receiver supports multiple output formats, but you advertise > only one. > Tha

Re: [PATCH v6 4/6] media: i2c: Add TDA1997x HDMI receiver driver

2018-01-30 Thread Hans Verkuil
On 01/31/2018 05:51 AM, Tim Harvey wrote: > On Mon, Jan 29, 2018 at 4:00 AM, Hans Verkuil wrote: >> On 01/25/2018 05:15 PM, Tim Harvey wrote: > Hmm. This receiver supports multiple output formats, but you advertise only one. That looks wrong. If nothing else, you should be ab

Re: [PATCH v6 4/6] media: i2c: Add TDA1997x HDMI receiver driver

2018-01-30 Thread Tim Harvey
On Mon, Jan 29, 2018 at 4:00 AM, Hans Verkuil wrote: > On 01/25/2018 05:15 PM, Tim Harvey wrote: >>> >>> Hmm. This receiver supports multiple output formats, but you advertise only >>> one. >>> That looks wrong. If nothing else, you should be able to switch between RGB >>> and >>> YUV 4:4:4 sin

Re: [PATCH v6 4/6] media: i2c: Add TDA1997x HDMI receiver driver

2018-01-29 Thread Hans Verkuil
On 01/25/2018 05:15 PM, Tim Harvey wrote: > On Mon, Jan 15, 2018 at 4:56 AM, Hans Verkuil wrote: >> On 12/28/2017 09:09 PM, Tim Harvey wrote: >>> Add support for the TDA1997x HDMI receivers. >>> >> >> This looks good. >> >> But there is one corner case that isn't handled in this driver: what if th

Re: [PATCH v6 4/6] media: i2c: Add TDA1997x HDMI receiver driver

2018-01-25 Thread Tim Harvey
On Mon, Jan 15, 2018 at 4:56 AM, Hans Verkuil wrote: > On 12/28/2017 09:09 PM, Tim Harvey wrote: >> Add support for the TDA1997x HDMI receivers. >> > > This looks good. > > But there is one corner case that isn't handled in this driver: what if there > is no AVI InfoFrame (e.g. you receive a DVI s

Re: [PATCH v6 4/6] media: i2c: Add TDA1997x HDMI receiver driver

2018-01-15 Thread Hans Verkuil
On 12/28/2017 09:09 PM, Tim Harvey wrote: > Add support for the TDA1997x HDMI receivers. > > Cc: Hans Verkuil > Signed-off-by: Tim Harvey > --- > v6: > - fix return on regulator enablei in tda1997x_set_power() (Fabio) > - replace copyright with SPDX tag (Philippe) > - fix colorspace handling

[PATCH v6 4/6] media: i2c: Add TDA1997x HDMI receiver driver

2017-12-28 Thread Tim Harvey
Add support for the TDA1997x HDMI receivers. Cc: Hans Verkuil Signed-off-by: Tim Harvey --- v6: - fix return on regulator enablei in tda1997x_set_power() (Fabio) - replace copyright with SPDX tag (Philippe) - fix colorspace handling (Hans) v5: - uppercase string constants - use v4l2_hdmi_r