Re: [PATCH v6 5/5] mtd: spi-nor: keep lock bits if they are non-volatile

2020-12-02 Thread Tudor.Ambarus
On 12/2/20 1:25 PM, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Am 2020-12-02 12:10, schrieb tudor.amba...@microchip.com: >> On 11/30/20 4:38 PM, Michael Walle wrote: > [..] > +    * indicated by

Re: [PATCH v6 5/5] mtd: spi-nor: keep lock bits if they are non-volatile

2020-12-02 Thread Michael Walle
Am 2020-12-02 12:10, schrieb tudor.amba...@microchip.com: On 11/30/20 4:38 PM, Michael Walle wrote: [..] +    * indicated by SNOR_F_WP_IS_VOLATILE. +    */ +   if (IS_ENABLED(CONFIG_MTD_SPI_NOR_WP_DISABLE) || +   (IS_ENABLED(CONFIG_MTD_SPI_NOR_WP_DISABLE_ON_VOLATILE) && + 

Re: [PATCH v6 5/5] mtd: spi-nor: keep lock bits if they are non-volatile

2020-12-02 Thread Tudor.Ambarus
On 11/30/20 4:38 PM, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Am 2020-11-28 11:17, schrieb tudor.amba...@microchip.com: >> On 11/26/20 10:26 PM, Michael Walle wrote: >>> EXTERNAL EMAIL: Do not click links or open

Re: [PATCH v6 5/5] mtd: spi-nor: keep lock bits if they are non-volatile

2020-11-30 Thread Michael Walle
Am 2020-11-28 11:17, schrieb tudor.amba...@microchip.com: On 11/26/20 10:26 PM, Michael Walle wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe Traditionally, linux unlocks the whole flash because there are legacy devices which has the write

Re: [PATCH v6 5/5] mtd: spi-nor: keep lock bits if they are non-volatile

2020-11-28 Thread Tudor.Ambarus
On 11/26/20 10:26 PM, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Traditionally, linux unlocks the whole flash because there are legacy > devices which has the write protections bits set by default at startup. > If you

[PATCH v6 5/5] mtd: spi-nor: keep lock bits if they are non-volatile

2020-11-26 Thread Michael Walle
Traditionally, linux unlocks the whole flash because there are legacy devices which has the write protections bits set by default at startup. If you actually want to use the flash protection bits, eg. because there is a read-only part for a bootloader, this automatic unlocking is harmful. If there