Re: [PATCH v6 5/6] Uprobes/sdt: Prevent multiple reference counter for same uprobe

Hi Ravi, On 07/27, Ravi Bangoria wrote: > > > I simply can't understand this "bool installed" > > > That boolean is needed because consumer_filter() returns false when this > function gets called first time from uprobe_register(). Ah yes, I forgot about the (ugly) 2-stage TRACE_REG_PERF_REGIS

Re: [PATCH v6 5/6] Uprobes/sdt: Prevent multiple reference counter for same uprobe

Hi Oleg, On 07/25/2018 04:38 PM, Oleg Nesterov wrote: > No, I can't understand this patch... > > On 07/16, Ravi Bangoria wrote: >> >> --- a/kernel/events/uprobes.c >> +++ b/kernel/events/uprobes.c >> @@ -63,6 +63,8 @@ static struct percpu_rw_semaphore dup_mmap_sem; >> >> /* Have a copy of origin

Re: [PATCH v6 5/6] Uprobes/sdt: Prevent multiple reference counter for same uprobe

No, I can't understand this patch... On 07/16, Ravi Bangoria wrote: > > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -63,6 +63,8 @@ static struct percpu_rw_semaphore dup_mmap_sem; > > /* Have a copy of original instruction */ > #define UPROBE_COPY_INSN 0 > +/* Reference

[PATCH v6 5/6] Uprobes/sdt: Prevent multiple reference counter for same uprobe

We assume to have only one reference counter for one uprobe. Don't allow user to register multiple uprobes having same inode+offset but different reference counter. Though, existing tools which already support SDT events creates normal uprobe and updates reference counter on their own. Allow 0 as