Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-29 Thread Rajendra Nayak
On 6/25/2020 8:55 PM, Matthias Kaehlcke wrote: On Wed, Jun 24, 2020 at 11:12:45AM -0700, Matthias Kaehlcke wrote: On Wed, Jun 24, 2020 at 07:00:05PM +0100, Mark Brown wrote: On Wed, Jun 24, 2020 at 10:55:36AM -0700, Matthias Kaehlcke wrote: On Wed, Jun 24, 2020 at 06:44:17PM +0100, Mark

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-25 Thread Matthias Kaehlcke
On Wed, Jun 24, 2020 at 11:12:45AM -0700, Matthias Kaehlcke wrote: > On Wed, Jun 24, 2020 at 07:00:05PM +0100, Mark Brown wrote: > > On Wed, Jun 24, 2020 at 10:55:36AM -0700, Matthias Kaehlcke wrote: > > > On Wed, Jun 24, 2020 at 06:44:17PM +0100, Mark Brown wrote: > > > > > > Wait, so *some* of

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-24 Thread Mark Brown
On Wed, Jun 24, 2020 at 11:12:45AM -0700, Matthias Kaehlcke wrote: > On Wed, Jun 24, 2020 at 07:00:05PM +0100, Mark Brown wrote: > > I'm not really reading any of this stuff for the series as a whole, as > > far as I could tell I'd reviewed all my bits and was hoping whatever > > random platform

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-24 Thread Matthias Kaehlcke
On Wed, Jun 24, 2020 at 07:00:05PM +0100, Mark Brown wrote: > On Wed, Jun 24, 2020 at 10:55:36AM -0700, Matthias Kaehlcke wrote: > > On Wed, Jun 24, 2020 at 06:44:17PM +0100, Mark Brown wrote: > > > > Wait, so *some* of the series should go together but not other bits? > > > But you want them

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-24 Thread Mark Brown
On Wed, Jun 24, 2020 at 10:55:36AM -0700, Matthias Kaehlcke wrote: > On Wed, Jun 24, 2020 at 06:44:17PM +0100, Mark Brown wrote: > > Wait, so *some* of the series should go together but not other bits? > > But you want them split up for some reason? > Yes, this will almost certainly be the case,

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-24 Thread Matthias Kaehlcke
On Wed, Jun 24, 2020 at 06:44:17PM +0100, Mark Brown wrote: > On Wed, Jun 24, 2020 at 10:39:48AM -0700, Matthias Kaehlcke wrote: > > On Wed, Jun 24, 2020 at 06:15:37PM +0100, Mark Brown wrote: > > > > Aren't there dependencies on earlier patches in the series? > > > Not to my knowledge. Patch

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-24 Thread Mark Brown
On Wed, Jun 24, 2020 at 10:39:48AM -0700, Matthias Kaehlcke wrote: > On Wed, Jun 24, 2020 at 06:15:37PM +0100, Mark Brown wrote: > > Aren't there dependencies on earlier patches in the series? > Not to my knowledge. Patch "[2/6] spi: spi-geni-qcom: Use OPP API to set > clk/perf state" depends on

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-24 Thread Matthias Kaehlcke
On Wed, Jun 24, 2020 at 06:15:37PM +0100, Mark Brown wrote: > On Wed, Jun 24, 2020 at 10:09:33AM -0700, Matthias Kaehlcke wrote: > > Hi Mark, > > > > do you plan to land this in your tree? > > > > I know you hate contentless pings, but since you acked this patch and > > usually don't seem to do

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-24 Thread Mark Brown
On Wed, Jun 24, 2020 at 10:09:33AM -0700, Matthias Kaehlcke wrote: > Hi Mark, > > do you plan to land this in your tree? > > I know you hate contentless pings, but since you acked this patch and > usually don't seem to do that when patches go through your tree I want > to make sure we aren't in

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-24 Thread Matthias Kaehlcke
Hi Mark, do you plan to land this in your tree? I know you hate contentless pings, but since you acked this patch and usually don't seem to do that when patches go through your tree I want to make sure we aren't in a situation where everybody thinks that the patch will go through someone else's

[PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-15 Thread Rajendra Nayak
QSPI needs to vote on a performance state of a power domain depending on the clock rate. Add support for it by specifying the perf state/clock rate as an OPP table in device tree. Signed-off-by: Rajendra Nayak Reviewed-by: Matthias Kaehlcke Acked-by: Mark Brown Cc: Alok Chauhan Cc: Akash