Re: [PATCH v6 6/8] soc: qcom: Add AOSS QMP genpd provider

2019-02-11 Thread Doug Anderson
Hi, On Tue, Feb 5, 2019 at 9:13 PM Bjorn Andersson wrote: > +static int qmp_pd_image_toggle(struct qmp_pd *res, bool enable) > +{ > + char buf[AOSS_QMP_PD_MSG_LEN]; > + > + memset(buf, 0, sizeof(buf)); Personally I find it safer/cleaner to do something like: char buf[AOSS_QMP_PD_MSG

[PATCH v6 6/8] soc: qcom: Add AOSS QMP genpd provider

2019-02-05 Thread Bjorn Andersson
The AOSS QMP genpd provider implements control over power-related resources related to low-power state associated with the remoteprocs in the system as well as control over a set of clocks related to debug hardware in the SoC. Tested-by: Sibi Sankar Tested-by: Sai Prakash Ranjan Reviewed-by: Sib