Re: [PATCH v6 7/7] jump_label: use defined macros instead of hard-coding for better readability

2013-12-18 Thread Jason Baron
On 12/15/2013 06:10 AM, Jiang Liu wrote: > On 12/14/2013 12:20 AM, Steven Rostedt wrote: >> On Wed, 11 Dec 2013 00:03:53 +0800 >> Jiang Liu wrote: >> >>> Use macro JUMP_LABEL_TRUE_BRANCH instead of hard-coding for better >>> readability. >> Looks good, just a little nit. (see below) >> >>>

Re: [PATCH v6 7/7] jump_label: use defined macros instead of hard-coding for better readability

2013-12-18 Thread Jason Baron
On 12/15/2013 06:10 AM, Jiang Liu wrote: On 12/14/2013 12:20 AM, Steven Rostedt wrote: On Wed, 11 Dec 2013 00:03:53 +0800 Jiang Liu liu...@gmail.com wrote: Use macro JUMP_LABEL_TRUE_BRANCH instead of hard-coding for better readability. Looks good, just a little nit. (see below)

Re: [PATCH v6 7/7] jump_label: use defined macros instead of hard-coding for better readability

2013-12-15 Thread Jiang Liu
On 12/14/2013 12:20 AM, Steven Rostedt wrote: > On Wed, 11 Dec 2013 00:03:53 +0800 > Jiang Liu wrote: > >> Use macro JUMP_LABEL_TRUE_BRANCH instead of hard-coding for better >> readability. > > Looks good, just a little nit. (see below) > >> >> Signed-off-by: Jiang Liu >> --- >>

Re: [PATCH v6 7/7] jump_label: use defined macros instead of hard-coding for better readability

2013-12-15 Thread Jiang Liu
On 12/14/2013 12:20 AM, Steven Rostedt wrote: On Wed, 11 Dec 2013 00:03:53 +0800 Jiang Liu liu...@gmail.com wrote: Use macro JUMP_LABEL_TRUE_BRANCH instead of hard-coding for better readability. Looks good, just a little nit. (see below) Signed-off-by: Jiang Liu liu...@gmail.com ---

Re: [PATCH v6 7/7] jump_label: use defined macros instead of hard-coding for better readability

2013-12-13 Thread Steven Rostedt
On Wed, 11 Dec 2013 00:03:53 +0800 Jiang Liu wrote: > Use macro JUMP_LABEL_TRUE_BRANCH instead of hard-coding for better > readability. Looks good, just a little nit. (see below) > > Signed-off-by: Jiang Liu > --- > include/linux/jump_label.h | 15 ++- > 1 file changed, 10

Re: [PATCH v6 7/7] jump_label: use defined macros instead of hard-coding for better readability

2013-12-13 Thread Steven Rostedt
[ added Jason Baron too (the original author) ] On Fri, 13 Dec 2013 16:00:41 + Will Deacon wrote: > On Tue, Dec 10, 2013 at 04:03:53PM +, Jiang Liu wrote: > > Use macro JUMP_LABEL_TRUE_BRANCH instead of hard-coding for better > > readability. > > > > Signed-off-by: Jiang Liu > > ---

Re: [PATCH v6 7/7] jump_label: use defined macros instead of hard-coding for better readability

2013-12-13 Thread Will Deacon
On Tue, Dec 10, 2013 at 04:03:53PM +, Jiang Liu wrote: > Use macro JUMP_LABEL_TRUE_BRANCH instead of hard-coding for better > readability. > > Signed-off-by: Jiang Liu > --- > include/linux/jump_label.h | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) Whilst this

Re: [PATCH v6 7/7] jump_label: use defined macros instead of hard-coding for better readability

2013-12-13 Thread Will Deacon
On Tue, Dec 10, 2013 at 04:03:53PM +, Jiang Liu wrote: Use macro JUMP_LABEL_TRUE_BRANCH instead of hard-coding for better readability. Signed-off-by: Jiang Liu liu...@gmail.com --- include/linux/jump_label.h | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-)

Re: [PATCH v6 7/7] jump_label: use defined macros instead of hard-coding for better readability

2013-12-13 Thread Steven Rostedt
[ added Jason Baron too (the original author) ] On Fri, 13 Dec 2013 16:00:41 + Will Deacon will.dea...@arm.com wrote: On Tue, Dec 10, 2013 at 04:03:53PM +, Jiang Liu wrote: Use macro JUMP_LABEL_TRUE_BRANCH instead of hard-coding for better readability. Signed-off-by: Jiang Liu

Re: [PATCH v6 7/7] jump_label: use defined macros instead of hard-coding for better readability

2013-12-13 Thread Steven Rostedt
On Wed, 11 Dec 2013 00:03:53 +0800 Jiang Liu liu...@gmail.com wrote: Use macro JUMP_LABEL_TRUE_BRANCH instead of hard-coding for better readability. Looks good, just a little nit. (see below) Signed-off-by: Jiang Liu liu...@gmail.com --- include/linux/jump_label.h | 15 ++-

[PATCH v6 7/7] jump_label: use defined macros instead of hard-coding for better readability

2013-12-10 Thread Jiang Liu
Use macro JUMP_LABEL_TRUE_BRANCH instead of hard-coding for better readability. Signed-off-by: Jiang Liu --- include/linux/jump_label.h | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h index

[PATCH v6 7/7] jump_label: use defined macros instead of hard-coding for better readability

2013-12-10 Thread Jiang Liu
Use macro JUMP_LABEL_TRUE_BRANCH instead of hard-coding for better readability. Signed-off-by: Jiang Liu liu...@gmail.com --- include/linux/jump_label.h | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h