Re: [PATCH v6 bpf-next 6/6] selftests/bpf: add test for bpf_seq_printf_btf helper

2020-09-28 Thread Alexei Starovoitov
On Mon, Sep 28, 2020 at 10:51:19AM -0700, Andrii Nakryiko wrote: > On Mon, Sep 28, 2020 at 7:14 AM Alan Maguire wrote: > > > > > > > > On Thu, 24 Sep 2020, Alexei Starovoitov wrote: > > > > > to whatever number, but printing single task_struct needs ~800 lines and > > > ~18kbytes. Humans can scrol

Re: [PATCH v6 bpf-next 6/6] selftests/bpf: add test for bpf_seq_printf_btf helper

2020-09-28 Thread Andrii Nakryiko
On Mon, Sep 28, 2020 at 7:14 AM Alan Maguire wrote: > > > > On Thu, 24 Sep 2020, Alexei Starovoitov wrote: > > > to whatever number, but printing single task_struct needs ~800 lines and > > ~18kbytes. Humans can scroll through that much spam, but can we make it less > > verbose by default somehow?

Re: [PATCH v6 bpf-next 6/6] selftests/bpf: add test for bpf_seq_printf_btf helper

2020-09-28 Thread Alan Maguire
On Thu, 24 Sep 2020, Alexei Starovoitov wrote: > to whatever number, but printing single task_struct needs ~800 lines and > ~18kbytes. Humans can scroll through that much spam, but can we make it less > verbose by default somehow? > May be not in this patch set, but in the follow up? > One app

Re: [PATCH v6 bpf-next 6/6] selftests/bpf: add test for bpf_seq_printf_btf helper

2020-09-24 Thread Alexei Starovoitov
On Wed, Sep 23, 2020 at 06:46:28PM +0100, Alan Maguire wrote: > Add a test verifying iterating over tasks and displaying BTF > representation of data succeeds. Note here that we do not display > the task_struct itself, as it will overflow the PAGE_SIZE limit on seq > data; instead we write task->f

[PATCH v6 bpf-next 6/6] selftests/bpf: add test for bpf_seq_printf_btf helper

2020-09-23 Thread Alan Maguire
Add a test verifying iterating over tasks and displaying BTF representation of data succeeds. Note here that we do not display the task_struct itself, as it will overflow the PAGE_SIZE limit on seq data; instead we write task->fs (a struct fs_struct). Suggested-by: Alexei Starovoitov Signed-off-