Re: [PATCH v7] checkkconfigsymbols.sh: reimplementation in python

2014-09-29 Thread Paul Bolle
Hi Michal, [This point I already conceded to Valentin, so my remarks are moot for Valentin's script.] On Mon, 2014-09-29 at 16:47 +0200, Michal Marek wrote: > On 2014-09-29 12:28, Paul Bolle wrote: > >> +STMT = r"^\s*(?:if|select|depends\s+on)\s+" + EXPR > > > > Could please make that "depends o

Re: [PATCH v7] checkkconfigsymbols.sh: reimplementation in python

2014-09-29 Thread Michal Marek
On 2014-09-29 12:28, Paul Bolle wrote: >> +STMT = r"^\s*(?:if|select|depends\s+on)\s+" + EXPR > > Could please make that "depends on"? Yes, it seems the yacc grammar > accepts any amount of whitespace, but that doesn't make it right to use > anything other than a single space. But then lines that

Re: [PATCH v7] checkkconfigsymbols.sh: reimplementation in python

2014-09-29 Thread Paul Bolle
On Mon, 2014-09-29 at 14:08 +0200, Valentin Rothberg wrote: > On Mon, Sep 29, 2014 at 12:28 PM, Paul Bolle wrote: > > On Sun, 2014-09-28 at 17:55 +0200, Valentin Rothberg wrote: > >> (d) only checks files under version control ('git ls-files') > > > > (The shell script is .git unaware. If you

Re: [PATCH v7] checkkconfigsymbols.sh: reimplementation in python

2014-09-29 Thread Valentin Rothberg
On Mon, Sep 29, 2014 at 12:28 PM, Paul Bolle wrote: > [Added linux-kbu...@vger.kernel.org.] > > On Sun, 2014-09-28 at 17:55 +0200, Valentin Rothberg wrote: >> The scripts/checkkconfigsymbols.sh script searches Kconfig features >> in the source code that are not defined in Kconfig. Such identifier

Re: [PATCH v7] checkkconfigsymbols.sh: reimplementation in python

2014-09-29 Thread Paul Bolle
[Added linux-kbu...@vger.kernel.org.] On Sun, 2014-09-28 at 17:55 +0200, Valentin Rothberg wrote: > The scripts/checkkconfigsymbols.sh script searches Kconfig features > in the source code that are not defined in Kconfig. Such identifiers > always evaluate to false and are the source of various k

[PATCH v7] checkkconfigsymbols.sh: reimplementation in python

2014-09-28 Thread Valentin Rothberg
The scripts/checkkconfigsymbols.sh script searches Kconfig features in the source code that are not defined in Kconfig. Such identifiers always evaluate to false and are the source of various kinds of bugs. However, the shell script is slow and it does not detect such broken references in Kbuild an