RE: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

2016-09-13 Thread Gao, Bin
On Fri, Sep 13, 2016 at 07:46:31AM, Paul Gortmaker wrote: >> On Tue, Sep 13, 2016 at 4:37 PM, Paul Gortmaker >> wrote: >> >> > This looks like an invalid address, and >> >> >> >> >> +MODULE_AUTHOR("Ajay Thomas >> >> >>

RE: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

2016-09-13 Thread Gao, Bin
On Fri, Sep 13, 2016 at 07:46:31AM, Paul Gortmaker wrote: >> On Tue, Sep 13, 2016 at 4:37 PM, Paul Gortmaker >> wrote: >> >> > This looks like an invalid address, and >> >> >> >> >> +MODULE_AUTHOR("Ajay Thomas >> >> >> +"); >> >> > >> >> > ...the same here. In fact it sure looks like two

Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

2016-09-13 Thread Paul Gortmaker
[Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver] On 13/09/2016 (Tue 17:35) Andy Shevchenko wrote: > On Tue, Sep 13, 2016 at 4:37 PM, Paul Gortmaker > <paul.gortma...@windriver.com> wrote: > >> > This looks like an invalid address, and > >> &g

Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

2016-09-13 Thread Paul Gortmaker
[Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver] On 13/09/2016 (Tue 17:35) Andy Shevchenko wrote: > On Tue, Sep 13, 2016 at 4:37 PM, Paul Gortmaker > wrote: > >> > This looks like an invalid address, and > >> > >

Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

2016-09-13 Thread Andy Shevchenko
On Tue, Sep 13, 2016 at 4:37 PM, Paul Gortmaker wrote: >> > This looks like an invalid address, and >> >> >> +MODULE_AUTHOR("Ajay Thomas "); >> > >> > ...the same here. In fact it sure looks like two names. Anyway I

Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

2016-09-13 Thread Andy Shevchenko
On Tue, Sep 13, 2016 at 4:37 PM, Paul Gortmaker wrote: >> > This looks like an invalid address, and >> >> >> +MODULE_AUTHOR("Ajay Thomas "); >> > >> > ...the same here. In fact it sure looks like two names. Anyway I just >> > got a >> > bounce when I tried to use it... >> >> It might be

Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

2016-09-13 Thread Paul Gortmaker
[Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver] On 13/09/2016 (Tue 10:02) Andy Shevchenko wrote: > On Tue, Sep 13, 2016 at 1:37 AM, Paul Gortmaker > <paul.gortma...@windriver.com> wrote: > >> Signed-off-by: Ajay Thomas <ajay.thomas.david.rajamanic...@intel

Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

2016-09-13 Thread Paul Gortmaker
[Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver] On 13/09/2016 (Tue 10:02) Andy Shevchenko wrote: > On Tue, Sep 13, 2016 at 1:37 AM, Paul Gortmaker > wrote: > >> Signed-off-by: Ajay Thomas > > > > This looks like an invalid address, and > &g

Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

2016-09-13 Thread Andy Shevchenko
On Tue, Sep 13, 2016 at 1:37 AM, Paul Gortmaker wrote: >> Signed-off-by: Ajay Thomas > > This looks like an invalid address, and >> +MODULE_AUTHOR("Ajay Thomas "); > > ...the

Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

2016-09-13 Thread Andy Shevchenko
On Tue, Sep 13, 2016 at 1:37 AM, Paul Gortmaker wrote: >> Signed-off-by: Ajay Thomas > > This looks like an invalid address, and >> +MODULE_AUTHOR("Ajay Thomas "); > > ...the same here. In fact it sure looks like two names. Anyway I just got a > bounce when I tried to use it... It might

Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

2016-09-12 Thread Paul Gortmaker
On Mon, Jul 25, 2016 at 5:59 PM, Bin Gao wrote: > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. > This driver is based on gpio-crystalcove.c. > > Signed-off-by: Ajay Thomas This looks like an invalid

Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

2016-09-12 Thread Paul Gortmaker
On Mon, Jul 25, 2016 at 5:59 PM, Bin Gao wrote: > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. > This driver is based on gpio-crystalcove.c. > > Signed-off-by: Ajay Thomas This looks like an invalid address, and > Signed-off-by: Bin Gao > Reviewed-by: Andy

Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

2016-08-11 Thread Linus Walleij
On Mon, Jul 25, 2016 at 11:59 PM, Bin Gao wrote: > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. > This driver is based on gpio-crystalcove.c. > > Signed-off-by: Ajay Thomas > Signed-off-by: Bin Gao

Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

2016-08-11 Thread Linus Walleij
On Mon, Jul 25, 2016 at 11:59 PM, Bin Gao wrote: > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. > This driver is based on gpio-crystalcove.c. > > Signed-off-by: Ajay Thomas > Signed-off-by: Bin Gao > Reviewed-by: Andy Shevchenko > Reviewed-by: Mika Westerberg >

[PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

2016-07-25 Thread Bin Gao
This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. This driver is based on gpio-crystalcove.c. Signed-off-by: Ajay Thomas Signed-off-by: Bin Gao Reviewed-by: Andy Shevchenko

[PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

2016-07-25 Thread Bin Gao
This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. This driver is based on gpio-crystalcove.c. Signed-off-by: Ajay Thomas Signed-off-by: Bin Gao Reviewed-by: Andy Shevchenko Reviewed-by: Mika Westerberg --- Changes in v7: - Fixed various coding style comments from Andy