Re: [PATCH v7] media: vb2: Take queue or device lock in mmap-related vb2 ioctl handlers

2014-07-02 Thread Laurent Pinchart
Hi Hans, On Wednesday 02 July 2014 08:33:47 Hans Verkuil wrote: > For now it is -ENOTIME for me. It's on my TODO list, but there are a number > of other things I want to finish first. No worries, I know how it feels. I just wanted to make sure you hadn't missed my e-mail. -- Regards, Laurent

Re: [PATCH v7] media: vb2: Take queue or device lock in mmap-related vb2 ioctl handlers

2014-07-01 Thread Hans Verkuil
For now it is -ENOTIME for me. It's on my TODO list, but there are a number of other things I want to finish first. Regards, Hans On 07/01/2014 11:08 PM, Laurent Pinchart wrote: > On Wednesday 25 June 2014 12:58:03 Sasha Levin wrote: >> Ping? > > Hans, I've replied to your previous e-ma

Re: [PATCH v7] media: vb2: Take queue or device lock in mmap-related vb2 ioctl handlers

2014-07-01 Thread Laurent Pinchart
On Wednesday 25 June 2014 12:58:03 Sasha Levin wrote: > Ping? Hans, I've replied to your previous e-mail with I'm of course fine with a different way to solve the race condition, if we can find a good one. Do you already know how you would like to solve this ? > On 05/23/2014 09:54 AM, Hans Ver

Re: [PATCH v7] media: vb2: Take queue or device lock in mmap-related vb2 ioctl handlers

2014-06-25 Thread Sasha Levin
Ping? On 05/23/2014 09:54 AM, Hans Verkuil wrote: > Hi Laurent, > > This patch caused a circular locking dependency as reported by Sasha Levin: > > https://lkml.org/lkml/2014/5/5/366 > > The reason is that copy_to/from_user is called in video_usercopy() with the > core lock held. The copy funct

Re: [PATCH v7] media: vb2: Take queue or device lock in mmap-related vb2 ioctl handlers

2014-05-26 Thread Laurent Pinchart
Hi Hans, On Friday 23 May 2014 15:54:29 Hans Verkuil wrote: > Hi Laurent, > > This patch caused a circular locking dependency as reported by Sasha Levin: > > https://lkml.org/lkml/2014/5/5/366 > > The reason is that copy_to/from_user is called in video_usercopy() with the > core lock held. The

Re: [PATCH v7] media: vb2: Take queue or device lock in mmap-related vb2 ioctl handlers

2014-05-23 Thread Hans Verkuil
Hi Laurent, This patch caused a circular locking dependency as reported by Sasha Levin: https://lkml.org/lkml/2014/5/5/366 The reason is that copy_to/from_user is called in video_usercopy() with the core lock held. The copy functions can fault which takes the mmap_sem. If it was just video_userc