Re: [PATCH v7] mm: Add memory allocation watchdog kernel thread.

2017-03-13 Thread Tetsuo Handa
Michal Hocko wrote: > On Sat 11-03-17 10:46:58, Tetsuo Handa wrote: > > In most cases, administrators can't capture even SysRq-t; let alone vmcore. > > Therefore, automatic watchdog is highly appreciated. Have you considered > > this aspect? > > yes I have. I tend to work with our SUSE L3 and ent

Re: [PATCH v7] mm: Add memory allocation watchdog kernel thread.

2017-03-13 Thread Michal Hocko
On Sat 11-03-17 10:46:58, Tetsuo Handa wrote: > Michal Hocko wrote: > > So, we have means to debug these issues. Some of them are rather coarse > > and your watchdog can collect much more and maybe give us a clue much > > quicker but we still have to judge whether all this is really needed > > beca

Re: [PATCH v7] mm: Add memory allocation watchdog kernel thread.

2017-03-10 Thread Tetsuo Handa
Michal Hocko wrote: > So, we have means to debug these issues. Some of them are rather coarse > and your watchdog can collect much more and maybe give us a clue much > quicker but we still have to judge whether all this is really needed > because it doesn't come for free. Have you considered this a

Re: [PATCH v7] mm: Add memory allocation watchdog kernel thread.

2017-03-10 Thread Michal Hocko
On Fri 10-03-17 20:19:58, Tetsuo Handa wrote: [...] > Or, did you mean "some additional examples of how this new code was used > to understand and improve real-world kernel problems" as how this patch > helped in [2] [3] ? > > Regarding [3] (now continued as > http://lkml.kernel.org/r/201703031948

Re: [PATCH v7] mm: Add memory allocation watchdog kernel thread.

2017-03-10 Thread Brian Foster
alloc_pages_nodemask+0x3e4/0x460 > [ 1210.564777] alloc_pages_current+0x97/0x1b0 > [ 1210.566017] bio_copy_kern+0xc9/0x180 > [ 1210.567116] blk_rq_map_kern+0x70/0x140 > [ 1210.568356] __scsi_execute.isra.22+0x13a/0x1e0 > [ 1210.569839] scsi_execute_req_flags+0x94/0x100 > [ 1210.571218] sr_

Re: [PATCH v7] mm: Add memory allocation watchdog kernel thread.

2017-03-10 Thread Tetsuo Handa
victim=1 oom_count=45896 [ 1278.241813] MemAlloc-Info: stalling=40 dying=1 exiting=0 victim=1 oom_count=45896 -- Regarding [2], Alexander, Brian and Dave can explain it better than I. But I think that "check threads which cannot make progress" principle is same. > (top-

Re: [PATCH v7] mm: Add memory allocation watchdog kernel thread.

2017-03-10 Thread Tetsuo Handa
Andrew Morton wrote: > On Tue, 28 Feb 2017 10:21:48 +0900 Tetsuo Handa > wrote: > > > This patch adds a watchdog which periodically reports number of memory > > allocating tasks, dying tasks and OOM victim tasks when some task is > > spending too long time inside __alloc_pages_slowpath(). This p

Re: [PATCH v7] mm: Add memory allocation watchdog kernel thread.

2017-03-10 Thread Michal Hocko
On Thu 09-03-17 14:37:51, Andrew Morton wrote: > On Thu, 9 Mar 2017 19:46:14 +0900 Tetsuo Handa > wrote: > > > Tetsuo Handa wrote: > > > This patch adds a watchdog which periodically reports number of memory > > > allocating tasks, dying tasks and OOM victim tasks when some task is > > > spendin

Re: [PATCH v7] mm: Add memory allocation watchdog kernel thread.

2017-03-09 Thread Andrew Morton
On Thu, 9 Mar 2017 19:46:14 +0900 Tetsuo Handa wrote: > Tetsuo Handa wrote: > > This patch adds a watchdog which periodically reports number of memory > > allocating tasks, dying tasks and OOM victim tasks when some task is > > spending too long time inside __alloc_pages_slowpath(). This patch a

Re: [PATCH v7] mm: Add memory allocation watchdog kernel thread.

2017-03-09 Thread Andrew Morton
On Tue, 28 Feb 2017 10:21:48 +0900 Tetsuo Handa wrote: > This patch adds a watchdog which periodically reports number of memory > allocating tasks, dying tasks and OOM victim tasks when some task is > spending too long time inside __alloc_pages_slowpath(). This patch also > serves as a hook for

Re: [PATCH v7] mm: Add memory allocation watchdog kernel thread.

2017-03-09 Thread Tetsuo Handa
Andrew, do you have any questions on this patch? I really need this patch for finding bugs which MM people overlook. Tetsuo Handa wrote: > This patch adds a watchdog which periodically reports number of memory > allocating tasks, dying tasks and OOM victim tasks when some task is > spending too lo