25.03.2021 01:23, John Hubbard пишет:
> On 3/24/21 3:11 PM, Dmitry Osipenko wrote:
>> 25.03.2021 01:01, John Hubbard пишет:
>>> On 3/24/21 2:31 PM, Dmitry Osipenko wrote:
...
> +#include
> +
> +struct cma_kobject {
> + struct cma *cma;
> + struct kobject kobj;
On 3/24/21 3:11 PM, Dmitry Osipenko wrote:
25.03.2021 01:01, John Hubbard пишет:
On 3/24/21 2:31 PM, Dmitry Osipenko wrote:
...
+#include
+
+struct cma_kobject {
+ struct cma *cma;
+ struct kobject kobj;
If you'll place the kobj as the first member of the struct, then
container_of
25.03.2021 00:55, Minchan Kim пишет:
>> The tags are incorrect, I haven't suggested this change.
> During the development, you have suggested many things
> to make it clean. That suggested-by couldn't represent
> all the detail but wanted to give credit for you, too
> since you spent the time to
25.03.2021 00:55, Minchan Kim пишет:
>>> +static ssize_t alloc_pages_success_show(struct kobject *kobj,
>>> + struct kobj_attribute *attr, char *buf)
>>> +{
>>> + struct cma *cma = cma_from_kobj(kobj);
>>> +
>>> + return sysfs_emit(buf, "%llu\n",
>>> +
25.03.2021 01:10, Dmitry Osipenko пишет:
> 25.03.2021 00:55, Minchan Kim пишет:
>>> There are no dereferences fixed by this patch.
>> Let me add this:
>> https://lore.kernel.org/linux-mm/20210316100433.17665-1-colin.k...@canonical.com/
>>
>
> The tag is invalid now, since you squashed the fix. I
25.03.2021 01:01, John Hubbard пишет:
> On 3/24/21 2:31 PM, Dmitry Osipenko wrote:
>> ...
>>> +#include
>>> +
>>> +struct cma_kobject {
>>> + struct cma *cma;
>>> + struct kobject kobj;
>>
>> If you'll place the kobj as the first member of the struct, then
>> container_of will be a no-op.
25.03.2021 00:55, Minchan Kim пишет:
>> There are no dereferences fixed by this patch.
> Let me add this:
> https://lore.kernel.org/linux-mm/20210316100433.17665-1-colin.k...@canonical.com/
>
The tag is invalid now, since you squashed the fix. I think you may add
"Co-developed-by: Colin Ian King
On 3/24/21 2:31 PM, Dmitry Osipenko wrote:
...
+#include
+
+struct cma_kobject {
+ struct cma *cma;
+ struct kobject kobj;
If you'll place the kobj as the first member of the struct, then
container_of will be a no-op.
However, *this does not matter*. Let's not get carried
On Thu, Mar 25, 2021 at 12:31:51AM +0300, Dmitry Osipenko wrote:
> 24.03.2021 23:55, Minchan Kim пишет:
> > Since CMA is getting used more widely, it's more important to
> > keep monitoring CMA statistics for system health since it's
> > directly related to user experience.
> >
> > This patch
25.03.2021 00:31, Dmitry Osipenko пишет:
>> Reported-by: Dmitry Osipenko
>> Tested-by: Dmitry Osipenko
>> Suggested-by: Dmitry Osipenko
> The tags are incorrect, I haven't suggested this change.
The reported-by also should be removed.
24.03.2021 23:55, Minchan Kim пишет:
> Since CMA is getting used more widely, it's more important to
> keep monitoring CMA statistics for system health since it's
> directly related to user experience.
>
> This patch introduces sysfs statistics for CMA, in order to provide
> some basic monitoring
Since CMA is getting used more widely, it's more important to
keep monitoring CMA statistics for system health since it's
directly related to user experience.
This patch introduces sysfs statistics for CMA, in order to provide
some basic monitoring of the CMA allocator.
* the number of CMA page
12 matches
Mail list logo
