Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Mark Brown
On Fri, Oct 12, 2018 at 11:43:13AM +, Marcel Ziswiler wrote: > On Fri, 2018-10-12 at 11:43 +0100, Russell King - ARM Linux wrote: > > The existing DT description is reasonable, and introducing ficticious > > regulators in DT to work around the implementation is not reasonable. > I don't think

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Mark Brown
On Fri, Oct 12, 2018 at 04:58:38PM +0300, Andy Shevchenko wrote: > On Fri, Oct 12, 2018 at 1:45 PM Russell King - ARM Linux > > Given that DT describes the hardware, not the software implementation, > > it must not change just because we move from GPIO numbers to GPIO > > descriptors. > > The exi

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Andy Shevchenko
On Fri, Oct 12, 2018 at 1:45 PM Russell King - ARM Linux wrote: > > On Fri, Oct 12, 2018 at 11:39:15AM +0100, Jon Hunter wrote: > > We had the same situation for Tegra124 Jetson TK1 but I don't think that > > adding a pseudo intermediate regulator is cleaner. If the GPIO controls > > more than one

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Marcel Ziswiler
On Fri, 2018-10-12 at 13:59 +0100, Russell King - ARM Linux wrote: > On Fri, Oct 12, 2018 at 11:43:13AM +, Marcel Ziswiler wrote: > > I don't think it is that fictitious as it makes it crystal clear > > that > > there is something shared with all its pros and cons. E.g. what > > happens > > if

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Russell King - ARM Linux
On Fri, Oct 12, 2018 at 11:43:13AM +, Marcel Ziswiler wrote: > I don't think it is that fictitious as it makes it crystal clear that > there is something shared with all its pros and cons. E.g. what happens > if one of them regulators wants to turn off while the other one still > needs power? T

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Marcel Ziswiler
On Fri, 2018-10-12 at 11:43 +0100, Russell King - ARM Linux wrote: > On Fri, Oct 12, 2018 at 11:39:15AM +0100, Jon Hunter wrote: > > We had the same situation for Tegra124 Jetson TK1 but I don't think > > that > > adding a pseudo intermediate regulator is cleaner. If the GPIO > > controls > > more

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Linus Walleij
On Fri, Oct 12, 2018 at 12:43 PM Russell King - ARM Linux wrote: > Given that DT describes the hardware, not the software implementation, > it must not change just because we move from GPIO numbers to GPIO > descriptors. > > The existing DT description is reasonable, and introducing ficticious >

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Russell King - ARM Linux
On Fri, Oct 12, 2018 at 11:39:15AM +0100, Jon Hunter wrote: > We had the same situation for Tegra124 Jetson TK1 but I don't think that > adding a pseudo intermediate regulator is cleaner. If the GPIO controls > more than one regulator, I don't see why is it necessary to change the > DT. There are s

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Jon Hunter
On 12/10/18 10:43, Marcel Ziswiler wrote: > On Thu, 2018-10-11 at 19:47 +0200, Linus Walleij wrote: >> On Thu, Oct 11, 2018 at 5:34 PM Marcel Ziswiler >> wrote: >> >>> I guess that is also what broke HDMI on Apalis/Colibri T30 causing >>> me >>> to submit a fix [1]. I may also help testing. >> >

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Jon Hunter
Hi Linus, On 11/10/18 18:45, Linus Walleij wrote: > Hi Jon, > > On Thu, Oct 11, 2018 at 5:00 PM Jon Hunter wrote: > >> This also appears to be causing a regression on the Tegra124 Jetson TK1 >> that also uses a shared GPIO for two regulators. The 2nd regulator that >> uses the GPIO now fails to

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Marcel Ziswiler
On Thu, 2018-10-11 at 19:47 +0200, Linus Walleij wrote: > On Thu, Oct 11, 2018 at 5:34 PM Marcel Ziswiler > wrote: > > > I guess that is also what broke HDMI on Apalis/Colibri T30 causing > > me > > to submit a fix [1]. I may also help testing. > > I see there are many ways to skin this cat. Ye

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-11 Thread Linus Walleij
On Thu, Oct 11, 2018 at 5:34 PM Marcel Ziswiler wrote: > I guess that is also what broke HDMI on Apalis/Colibri T30 causing me > to submit a fix [1]. I may also help testing. I see there are many ways to skin this cat. Does this patch fix things for you as well? https://marc.info/?l=linux-kerne

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-11 Thread Linus Walleij
Hi Jon, On Thu, Oct 11, 2018 at 5:00 PM Jon Hunter wrote: > This also appears to be causing a regression on the Tegra124 Jetson TK1 > that also uses a shared GPIO for two regulators. The 2nd regulator that > uses the GPIO now fails to probe [0] ... > > [0.680021] +5V_SATA: supplied by +5V_SY

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-11 Thread Marcel Ziswiler
Hi Linus On Thu, 2018-10-11 at 16:00 +0100, Jon Hunter wrote: > Hi Linus, > > On 11/10/18 10:29, Linus Walleij wrote: > > On Thu, Oct 11, 2018 at 11:01 AM Marek Szyprowski > > wrote: > > > > > I've just noticed that this patch causes regression on Samsung > > > Exynos4412-based Trats2 board. Co

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-11 Thread Jon Hunter
Hi Linus, On 11/10/18 10:29, Linus Walleij wrote: > On Thu, Oct 11, 2018 at 11:01 AM Marek Szyprowski > wrote: > >> I've just noticed that this patch causes regression on Samsung >> Exynos4412-based Trats2 board. Conversion to GPIO descriptor breaks >> operation when regulators used shared GPIO:

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-11 Thread Mark Brown
On Thu, Oct 11, 2018 at 11:46:59AM +0200, Marek Szyprowski wrote: > On 2018-10-11 11:29, Linus Walleij wrote: > > On Thu, Oct 11, 2018 at 11:01 AM Marek Szyprowski > >> I've just noticed that this patch causes regression on Samsung > >> Exynos4412-based Trats2 board. Conversion to GPIO descriptor

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-11 Thread Marek Szyprowski
Hi Linus, On 2018-10-11 11:29, Linus Walleij wrote: > On Thu, Oct 11, 2018 at 11:01 AM Marek Szyprowski > wrote: > >> I've just noticed that this patch causes regression on Samsung >> Exynos4412-based Trats2 board. Conversion to GPIO descriptor breaks >> operation when regulators used shared GPIO

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-11 Thread Linus Walleij
On Thu, Oct 11, 2018 at 11:01 AM Marek Szyprowski wrote: > I've just noticed that this patch causes regression on Samsung > Exynos4412-based Trats2 board. Conversion to GPIO descriptor breaks > operation when regulators used shared GPIO: sii9234 i2c driver > is not able to get vcc33mhl regulator

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-11 Thread Marek Szyprowski
Hi All, On 2018-09-06 14:24, Linus Walleij wrote: > As we augmented the regulator core to accept a GPIO descriptor instead > of a GPIO number, we can augment the fixed GPIO regulator to look up > and pass that descriptor directly from device tree or board GPIO > descriptor look up tables. > > Some

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-01 Thread Linus Walleij
On Mon, Oct 1, 2018 at 10:36 PM Fabio Estevam wrote: > On Mon, Oct 1, 2018 at 5:17 PM Linus Walleij wrote: > > > > reg_enet_3v3: regulator-enet-3v3 { > > > compatible = "regulator-fixed"; > > > pinctrl-names = "default"; > > > pinctrl-0 = <&pinctrl_enet_3v3>; > > >

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-01 Thread Fabio Estevam
Hi Linus, On Mon, Oct 1, 2018 at 5:17 PM Linus Walleij wrote: > > reg_enet_3v3: regulator-enet-3v3 { > > compatible = "regulator-fixed"; > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_enet_3v3>; > > regulator-name = "enet_3v3"; > > regulator-min-

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-01 Thread Linus Walleij
On Mon, Oct 1, 2018 at 8:53 PM Leonard Crestez wrote: > This patch seems to break network booting on imx6sx-sdb in linux-next > because the enet phy regulator is not on. Reverting the patch fixes > boot. Thanks for reporting. John Stultz reported the same problem I'm trying to debug it. > Here

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-01 Thread Leonard Crestez
Hello, This patch seems to break network booting on imx6sx-sdb in linux-next because the enet phy regulator is not on. Reverting the patch fixes boot. Here is the regulator definition: reg_enet_3v3: regulator-enet-3v3 { compatible = "regulator-fixed"; pinctrl-names = "default";

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-09-29 Thread Linus Walleij
On Sat, Sep 29, 2018 at 1:32 AM John Stultz wrote: > Anders recently noted a regression in -next when running HiKey, > where USB fails to function. I took a look and could reproduce this > as well, and after some unsuccessful muddling about in the usb > changes, I bisected it down to your comm

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-09-28 Thread John Stultz
On Thu, Sep 6, 2018 at 6:01 AM Linus Walleij wrote: > > As we augmented the regulator core to accept a GPIO descriptor instead > of a GPIO number, we can augment the fixed GPIO regulator to look up > and pass that descriptor directly from device tree or board GPIO > descriptor look up tables. > >

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-09-11 Thread Mike Rapoport
On Thu, Sep 06, 2018 at 02:24:36PM +0200, Linus Walleij wrote: > As we augmented the regulator core to accept a GPIO descriptor instead > of a GPIO number, we can augment the fixed GPIO regulator to look up > and pass that descriptor directly from device tree or board GPIO > descriptor look up tabl

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-09-10 Thread Janusz Krzysztofik
Hi Linus, On Thursday, September 6, 2018 2:24:36 PM CEST Linus Walleij wrote: > As we augmented the regulator core to accept a GPIO descriptor instead > of a GPIO number, we can augment the fixed GPIO regulator to look up > and pass that descriptor directly from device tree or board GPIO > descrip

[PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-09-06 Thread Linus Walleij
As we augmented the regulator core to accept a GPIO descriptor instead of a GPIO number, we can augment the fixed GPIO regulator to look up and pass that descriptor directly from device tree or board GPIO descriptor look up tables. Some boards just auto-enumerate their fixed regulator platform dev