Re: [PATCH v7]pwm: add BCM2835 PWM driver

2014-10-15 Thread Bart Tanghe
On 2014-10-14 15:54, Thierry Reding wrote: > The above indicates that it would be 0x00, in which case it might be > better to just do... > > value &= ~(PWM_CONTROL_MASK << (PWM_CONTROL_STRIDE * pwm->hwpwm)); > > ... and get rid of DEFAULT_PWM_MODE. Indeed, this has to be 0x00. PWM_CONTROL

Re: [PATCH v7]pwm: add BCM2835 PWM driver

2014-10-14 Thread Thierry Reding
On Wed, Oct 08, 2014 at 12:14:32PM +0200, Bart Tanghe wrote: [...] > diff --git a/drivers/pwm/pwm-bcm2835.c b/drivers/pwm/pwm-bcm2835.c [...] > +static void bcm2835_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm) > +{ > + struct bcm2835_pwm *pc = to_bcm2835_pwm(chip); > + u32 value;

Re: [PATCH v7]pwm: add BCM2835 PWM driver

2014-10-08 Thread Stephen Warren
On 10/08/2014 03:14 AM, Bart Tanghe wrote: > Add pwm driver for Broadcom BCM2835 processor (Raspberry Pi) Acked-by: Stephen Warren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.k

Re: [PATCH v7]pwm: add BCM2835 PWM driver

2014-10-08 Thread Bart Tanghe
On 2014-10-08 14:19, Thierry Reding wrote: > On Wed, Oct 08, 2014 at 12:14:32PM +0200, Bart Tanghe wrote: >> Add pwm driver for Broadcom BCM2835 processor (Raspberry Pi) >> >> Signed-off-by: Bart Tanghe >> --- >> Changed in v7: >> - clean up the shameful clk_enable error handling introduced in v6

Re: [PATCH v7]pwm: add BCM2835 PWM driver

2014-10-08 Thread Thierry Reding
On Wed, Oct 08, 2014 at 12:14:32PM +0200, Bart Tanghe wrote: > Add pwm driver for Broadcom BCM2835 processor (Raspberry Pi) > > Signed-off-by: Bart Tanghe > --- > Changed in v7: > - clean up the shameful clk_enable error handling introduced in v6 > - clean up the code nits > > diff --git a/Doc

[PATCH v7]pwm: add BCM2835 PWM driver

2014-10-08 Thread Bart Tanghe
Add pwm driver for Broadcom BCM2835 processor (Raspberry Pi) Signed-off-by: Bart Tanghe --- Changed in v7: - clean up the shameful clk_enable error handling introduced in v6 - clean up the code nits diff --git a/Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt b/Documentation/devicetree/