Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Hi Greg, On Di, 2016-12-06 at 11:02 +0100, Greg KH wrote: > On Sun, Dec 04, 2016 at 11:53:53AM +0100, Manuel Schölling wrote: > > Reviewed-by: Andrey Utkin > > Tested-by: Andrey Utkin > > Tested-by: Adam Borowski > > >

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Hi Greg, On Di, 2016-12-06 at 11:02 +0100, Greg KH wrote: > On Sun, Dec 04, 2016 at 11:53:53AM +0100, Manuel Schölling wrote: > > Reviewed-by: Andrey Utkin > > Tested-by: Andrey Utkin > > Tested-by: Adam Borowski > > > > -- > > Changes in v7: > > - Add new callback to consw struct for

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Sun, Dec 04, 2016 at 11:53:53AM +0100, Manuel Schölling wrote: > Reviewed-by: Andrey Utkin > Tested-by: Andrey Utkin > Tested-by: Adam Borowski > > -- > Changes in v7: > - Add new callback to consw struct for

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Sun, Dec 04, 2016 at 11:53:53AM +0100, Manuel Schölling wrote: > Reviewed-by: Andrey Utkin > Tested-by: Andrey Utkin > Tested-by: Adam Borowski > > -- > Changes in v7: > - Add new callback to consw struct for flushing video console driver's > scrollback buffer. Fixes issues with

[PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Reviewed-by: Andrey Utkin Tested-by: Andrey Utkin Tested-by: Adam Borowski -- Changes in v7: - Add new callback to consw struct for flushing video console driver's scrollback buffer. Fixes issues with escape

[PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Reviewed-by: Andrey Utkin Tested-by: Andrey Utkin Tested-by: Adam Borowski -- Changes in v7: - Add new callback to consw struct for flushing video console driver's scrollback buffer. Fixes issues with escape sequence '\e[3J' reported by Adam Borowski (kilob...@angband.pl). - Fix

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Thu, Dec 01, 2016 at 10:03:23PM +0100, Manuel Schölling wrote: > Hi Andrey, > > On Di, 2016-11-29 at 10:01 +, Andrey Utkin wrote: > > On Mon, Nov 28, 2016 at 10:28:19PM +0100, Manuel Schölling wrote: > > Regarding logout scrollback clearing not working for me. ncurses-6.0-rc1 > > which I

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Thu, Dec 01, 2016 at 10:03:23PM +0100, Manuel Schölling wrote: > Hi Andrey, > > On Di, 2016-11-29 at 10:01 +, Andrey Utkin wrote: > > On Mon, Nov 28, 2016 at 10:28:19PM +0100, Manuel Schölling wrote: > > Regarding logout scrollback clearing not working for me. ncurses-6.0-rc1 > > which I

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Hi Andrey, On Di, 2016-11-29 at 10:01 +, Andrey Utkin wrote: > On Mon, Nov 28, 2016 at 10:28:19PM +0100, Manuel Schölling wrote: > Regarding logout scrollback clearing not working for me. ncurses-6.0-rc1 > which I tested it with is the latest available in Gentoo portage, please > confirm

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Hi Andrey, On Di, 2016-11-29 at 10:01 +, Andrey Utkin wrote: > On Mon, Nov 28, 2016 at 10:28:19PM +0100, Manuel Schölling wrote: > Regarding logout scrollback clearing not working for me. ncurses-6.0-rc1 > which I tested it with is the latest available in Gentoo portage, please > confirm

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Hi Andrey, On Di, 2016-11-29 at 10:01 +, Andrey Utkin wrote: > Regarding logout scrollback clearing not working for me. ncurses-6.0-rc1 > which I tested it with is the latest available in Gentoo portage, please > confirm whether I need any newer version, or should I tune something > else. I'd

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Hi Andrey, On Di, 2016-11-29 at 10:01 +, Andrey Utkin wrote: > Regarding logout scrollback clearing not working for me. ncurses-6.0-rc1 > which I tested it with is the latest available in Gentoo portage, please > confirm whether I need any newer version, or should I tune something > else. I'd

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Tue, Nov 29, 2016 at 10:01:15AM +, Andrey Utkin wrote: > Regarding logout scrollback clearing not working for me. ncurses-6.0-rc1 > which I tested it with is the latest available in Gentoo portage, please > confirm whether I need any newer version, or should I tune something > else. I'd

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Tue, Nov 29, 2016 at 10:01:15AM +, Andrey Utkin wrote: > Regarding logout scrollback clearing not working for me. ncurses-6.0-rc1 > which I tested it with is the latest available in Gentoo portage, please > confirm whether I need any newer version, or should I tune something > else. I'd

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Mon, Nov 28, 2016 at 10:28:19PM +0100, Manuel Schölling wrote: > Hi Andrey, > > Adam already discussed some of your notes, but I want to catch up one > this one: > > On So, 2016-11-27 at 21:37 +, Andrey Utkin wrote: > > I see the user experience is subpar to what I'm accustomed to (I use

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Mon, Nov 28, 2016 at 10:28:19PM +0100, Manuel Schölling wrote: > Hi Andrey, > > Adam already discussed some of your notes, but I want to catch up one > this one: > > On So, 2016-11-27 at 21:37 +, Andrey Utkin wrote: > > I see the user experience is subpar to what I'm accustomed to (I use

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Hi Andrey, Adam already discussed some of your notes, but I want to catch up one this one: On So, 2016-11-27 at 21:37 +, Andrey Utkin wrote: > I see the user experience is subpar to what I'm accustomed to (I use > Konsole and "Clear Scrollback and Reset" action, default shortcut is >

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Hi Andrey, Adam already discussed some of your notes, but I want to catch up one this one: On So, 2016-11-27 at 21:37 +, Andrey Utkin wrote: > I see the user experience is subpar to what I'm accustomed to (I use > Konsole and "Clear Scrollback and Reset" action, default shortcut is >

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Mo, 2016-11-28 at 00:53 +0100, Adam Borowski wrote: > \e[3J works well now, thanks! Great to hear that! > Tested-by: Adam Borowski Thanks, Adam, for spending all this time testing the patches!

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Mo, 2016-11-28 at 00:53 +0100, Adam Borowski wrote: > \e[3J works well now, thanks! Great to hear that! > Tested-by: Adam Borowski Thanks, Adam, for spending all this time testing the patches!

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Mon, Nov 28, 2016 at 12:15:48AM +0100, Adam Borowski wrote: > On Sun, Nov 27, 2016 at 09:37:30PM +, Andrey Utkin wrote: > > I've just patched next-20161125 with this set and given it a run. > > > > Scrollback persistence works fine, just as in earlier versions. > > > > This time I didn't

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Mon, Nov 28, 2016 at 12:15:48AM +0100, Adam Borowski wrote: > On Sun, Nov 27, 2016 at 09:37:30PM +, Andrey Utkin wrote: > > I've just patched next-20161125 with this set and given it a run. > > > > Scrollback persistence works fine, just as in earlier versions. > > > > This time I didn't

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

\e[3J works well now, thanks! I haven't found any more problems; your changes also appear to make no regressions in at least nouveau fb (which obviously doesn't have this goodie yet). Patch 2 doesn't apply cleanly on current Linus' tree but it's just a matter of more fuzz than "git am" allows.

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

\e[3J works well now, thanks! I haven't found any more problems; your changes also appear to make no regressions in at least nouveau fb (which obviously doesn't have this goodie yet). Patch 2 doesn't apply cleanly on current Linus' tree but it's just a matter of more fuzz than "git am" allows.

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

* Adam Borowski , 2016-11-28, 00:15: clear(1) doesn't wipe the scrollback at all, it is still reachable, all of it. It does for me on the console. The man page says: # clear clears your screen if this is possible, including its scrollback # buffer (if the extended "E3"

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

* Adam Borowski , 2016-11-28, 00:15: clear(1) doesn't wipe the scrollback at all, it is still reachable, all of it. It does for me on the console. The man page says: # clear clears your screen if this is possible, including its scrollback # buffer (if the extended "E3" capability is

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Sun, Nov 27, 2016 at 09:37:30PM +, Andrey Utkin wrote: > I've just patched next-20161125 with this set and given it a run. > > Scrollback persistence works fine, just as in earlier versions. > > This time I didn't forget to test clear operation. > > The only important concern is that

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Sun, Nov 27, 2016 at 09:37:30PM +, Andrey Utkin wrote: > I've just patched next-20161125 with this set and given it a run. > > Scrollback persistence works fine, just as in earlier versions. > > This time I didn't forget to test clear operation. > > The only important concern is that

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Hi Manuel, I've just patched next-20161125 with this set and given it a run. Scrollback persistence works fine, just as in earlier versions. This time I didn't forget to test clear operation. The only important concern is that after logout, the scrollback is not wiped by /bin/login or

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Hi Manuel, I've just patched next-20161125 with this set and given it a run. Scrollback persistence works fine, just as in earlier versions. This time I didn't forget to test clear operation. The only important concern is that after logout, the scrollback is not wiped by /bin/login or

[PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Changes in v7: - Add new callback to consw struct for flushing video console driver's scrollback buffer. Fixes issues with escape sequence '\e[3J' reported by Adam Borowski (kilob...@angband.pl). - Fix style issues Changes in v6: - Change of check if feature is enabled in

[PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Changes in v7: - Add new callback to consw struct for flushing video console driver's scrollback buffer. Fixes issues with escape sequence '\e[3J' reported by Adam Borowski (kilob...@angband.pl). - Fix style issues Changes in v6: - Change of check if feature is enabled in