Re: [PATCH v7 0/5] generate full callchain cursor entries for inlined frames

2017-10-24 Thread Namhyung Kim
Hi Arnaldo, On Tue, Oct 24, 2017 at 10:27:42AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Oct 23, 2017 at 09:39:57PM +0200, Milian Wolff escreveu: > > So to fix this all, I guess the suggested approach by Namhyung would be > > best, > > i.e. fixup my initial match_addresses to take the map

Re: [PATCH v7 0/5] generate full callchain cursor entries for inlined frames

2017-10-24 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 23, 2017 at 09:39:57PM +0200, Milian Wolff escreveu: > So to fix this all, I guess the suggested approach by Namhyung would be best, > i.e. fixup my initial match_addresses to take the map, and then if the map is > valid also take the dso into account when comparing the addresses: >

Re: [PATCH v7 0/5] generate full callchain cursor entries for inlined frames

2017-10-23 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 23, 2017 at 09:39:57PM +0200, Milian Wolff escreveu: > On Montag, 23. Oktober 2017 21:04:53 CEST Arnaldo Carvalho de Melo wrote: > > Em Fri, Oct 20, 2017 at 10:21:03PM +0200, Milian Wolff escreveu: > > > On Freitag, 20. Oktober 2017 18:15:40 CEST Arnaldo Carvalho de Melo wrote: > > > >

Re: [PATCH v7 0/5] generate full callchain cursor entries for inlined frames

2017-10-23 Thread Milian Wolff
On Montag, 23. Oktober 2017 21:04:53 CEST Arnaldo Carvalho de Melo wrote: > Em Fri, Oct 20, 2017 at 10:21:03PM +0200, Milian Wolff escreveu: > > On Freitag, 20. Oktober 2017 18:15:40 CEST Arnaldo Carvalho de Melo wrote: > > > Em Thu, Oct 19, 2017 at 01:38:31PM +0200, Milian Wolff escreveu: > > > >

Re: [PATCH v7 0/5] generate full callchain cursor entries for inlined frames

2017-10-23 Thread Milian Wolff
On Montag, 23. Oktober 2017 16:29:35 CEST Arnaldo Carvalho de Melo wrote: > Em Fri, Oct 20, 2017 at 10:21:03PM +0200, Milian Wolff escreveu: > > On Freitag, 20. Oktober 2017 18:15:40 CEST Arnaldo Carvalho de Melo wrote: > > > Em Thu, Oct 19, 2017 at 01:38:31PM +0200, Milian Wolff escreveu: > > > >

Re: [PATCH v7 0/5] generate full callchain cursor entries for inlined frames

2017-10-23 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 20, 2017 at 10:21:03PM +0200, Milian Wolff escreveu: > On Freitag, 20. Oktober 2017 18:15:40 CEST Arnaldo Carvalho de Melo wrote: > > Em Thu, Oct 19, 2017 at 01:38:31PM +0200, Milian Wolff escreveu: > > > This series of patches completely reworks the way inline frames are > > > handled.

Re: [PATCH v7 0/5] generate full callchain cursor entries for inlined frames

2017-10-23 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 20, 2017 at 10:21:03PM +0200, Milian Wolff escreveu: > On Freitag, 20. Oktober 2017 18:15:40 CEST Arnaldo Carvalho de Melo wrote: > > Em Thu, Oct 19, 2017 at 01:38:31PM +0200, Milian Wolff escreveu: > > > This series of patches completely reworks the way inline frames are > > > handled.

Re: [PATCH v7 0/5] generate full callchain cursor entries for inlined frames

2017-10-20 Thread Milian Wolff
On Freitag, 20. Oktober 2017 18:15:40 CEST Arnaldo Carvalho de Melo wrote: > Em Thu, Oct 19, 2017 at 01:38:31PM +0200, Milian Wolff escreveu: > > This series of patches completely reworks the way inline frames are > > handled. Instead of querying for the inline nodes on-demand in the > > individual

Re: [PATCH v7 0/5] generate full callchain cursor entries for inlined frames

2017-10-20 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 19, 2017 at 01:38:31PM +0200, Milian Wolff escreveu: > This series of patches completely reworks the way inline frames are handled. > Instead of querying for the inline nodes on-demand in the individual tools, > we now create proper callchain nodes for inlined frames. The advantages thi

[PATCH v7 0/5] generate full callchain cursor entries for inlined frames

2017-10-19 Thread Milian Wolff
This series of patches completely reworks the way inline frames are handled. Instead of querying for the inline nodes on-demand in the individual tools, we now create proper callchain nodes for inlined frames. The advantages this approach brings are numerous: - less duplicated code in the individu