Re: [PATCH v7 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

2020-11-03 Thread Marc Kleine-Budde
On 11/3/20 2:36 PM, Ondrej Ille wrote: > Hello Marc, > > thank you for review, I appreciate it. We will process all your notes, and get > rid of uin32_t and bitfields then. > > As Pavel pointed out, there are user space tests using this stuff, so it is > not just search and replace work. We will

Re: [PATCH v7 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

2020-11-03 Thread Marc Kleine-Budde
On 11/3/20 11:00 AM, Pavel Pisa wrote: > On Saturday 31 of October 2020 12:35:11 Marc Kleine-Budde wrote: >> On 10/30/20 11:19 PM, Pavel Pisa wrote: >>> This driver adds support for the CTU CAN FD open-source IP core. >> >> Please fix the following checkpatch warnings/errors: > > Yes I recheck wit

Re: [PATCH v7 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

2020-11-03 Thread Pavel Pisa
Hello Marc, thanks for response On Saturday 31 of October 2020 12:35:11 Marc Kleine-Budde wrote: > On 10/30/20 11:19 PM, Pavel Pisa wrote: > > This driver adds support for the CTU CAN FD open-source IP core. > > Please fix the following checkpatch warnings/errors: Yes I recheck with actual check

Re: [PATCH v7 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

2020-10-31 Thread Marc Kleine-Budde
On 10/30/20 11:19 PM, Pavel Pisa wrote: > This driver adds support for the CTU CAN FD open-source IP core. Please fix the following spelling mistakes: --- a/drivers/net/can/ctucanfd/ctucanfd_base.c +++ b/drivers/net/can/ctucanfd/ctucanfd_base.c @@ -752,7 +752,7 @@ static void ctucan_tx_interrupt(

Re: [PATCH v7 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

2020-10-31 Thread Marc Kleine-Budde
On 10/30/20 11:19 PM, Pavel Pisa wrote: > This driver adds support for the CTU CAN FD open-source IP core. Please fix the following checkpatch warnings/errors: drivers/net/can/ctucanfd/ctucanfd_base.c WARNING: Possi

[PATCH v7 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

2020-10-30 Thread Pavel Pisa
This driver adds support for the CTU CAN FD open-source IP core. More documentation and core sources at project page (https://gitlab.fel.cvut.cz/canbus/ctucanfd_ip_core). The core integration to Xilinx Zynq system as platform driver is available (https://gitlab.fel.cvut.cz/canbus/zynq/zynq-can-sja1