Re: [PATCH v7 03/28] x86/asm/suspend: use SYM_DATA for data

2019-02-05 Thread Borislav Petkov
On Tue, Feb 05, 2019 at 08:34:09AM +0100, Jiri Slaby wrote: > I also suggest noticing the size 0 -> 8 change ;). Ha! And one would think that binutils would've seen the ".quad 0" in the previous definition and do a proper size but that wouldn't have worked most likely, because before it was a

Re: [PATCH v7 03/28] x86/asm/suspend: use SYM_DATA for data

2019-02-04 Thread Jiri Slaby
On 04. 02. 19, 21:18, Borislav Petkov wrote: >> --- a/arch/x86/kernel/acpi/wakeup_64.S >> +++ b/arch/x86/kernel/acpi/wakeup_64.S >> @@ -133,4 +133,4 @@ saved_rbx: .quad 0 >> saved_rip: .quad 0 >> saved_rsp: .quad 0 >> >> -ENTRY(saved_magic) .quad 0 >>

Re: [PATCH v7 03/28] x86/asm/suspend: use SYM_DATA for data

2019-02-04 Thread Borislav Petkov
On Wed, Jan 30, 2019 at 01:46:46PM +0100, Jiri Slaby wrote: > Some global data in the suspend code were marked as `ENTRY'. ENTRY was > intended for functions and shall be paired with ENDPROC. ENTRY also > aligns symbols which creates unnecessary holes here between data. Since > we are dropping

[PATCH v7 03/28] x86/asm/suspend: use SYM_DATA for data

2019-01-30 Thread Jiri Slaby
Some global data in the suspend code were marked as `ENTRY'. ENTRY was intended for functions and shall be paired with ENDPROC. ENTRY also aligns symbols which creates unnecessary holes here between data. Since we are dropping historical markings, make proper use of newly added SYM_DATA in this