Re: [PATCH v7 05/14] sched: Introduce a sched_feat for Energy Aware Scheduling

2018-10-04 Thread Quentin Perret
On Wednesday 03 Oct 2018 at 18:24:35 (+0200), Peter Zijlstra wrote: > Yeah, sysctl, see for example: sysctl.kernel.numa_balancing and the > sched_numa_balancing static_key that goes with it. OK, that works for me. > I would default enable EAS if the EM is there and valid, but allow > people to

Re: [PATCH v7 05/14] sched: Introduce a sched_feat for Energy Aware Scheduling

2018-10-04 Thread Quentin Perret
On Wednesday 03 Oct 2018 at 18:24:35 (+0200), Peter Zijlstra wrote: > Yeah, sysctl, see for example: sysctl.kernel.numa_balancing and the > sched_numa_balancing static_key that goes with it. OK, that works for me. > I would default enable EAS if the EM is there and valid, but allow > people to

Re: [PATCH v7 05/14] sched: Introduce a sched_feat for Energy Aware Scheduling

2018-10-03 Thread Peter Zijlstra
On Tue, Oct 02, 2018 at 02:08:21PM +0100, Quentin Perret wrote: > On Tuesday 02 Oct 2018 at 14:34:16 (+0200), Peter Zijlstra wrote: > > So these are debug knobs.. I would expect there to be a regular > > static_key that is controlled by the presence of EM data. > > Right, the issue I'm trying to

Re: [PATCH v7 05/14] sched: Introduce a sched_feat for Energy Aware Scheduling

2018-10-03 Thread Peter Zijlstra
On Tue, Oct 02, 2018 at 02:08:21PM +0100, Quentin Perret wrote: > On Tuesday 02 Oct 2018 at 14:34:16 (+0200), Peter Zijlstra wrote: > > So these are debug knobs.. I would expect there to be a regular > > static_key that is controlled by the presence of EM data. > > Right, the issue I'm trying to

Re: [PATCH v7 05/14] sched: Introduce a sched_feat for Energy Aware Scheduling

2018-10-02 Thread Quentin Perret
On Tuesday 02 Oct 2018 at 14:34:16 (+0200), Peter Zijlstra wrote: > On Wed, Sep 12, 2018 at 10:13:00AM +0100, Quentin Perret wrote: > > In order to make sure Energy Aware Scheduling (EAS) doesn't hurt > > systems not using it, add a new sched_feat, called ENERGY_AWARE, > > guarding the access to

Re: [PATCH v7 05/14] sched: Introduce a sched_feat for Energy Aware Scheduling

2018-10-02 Thread Quentin Perret
On Tuesday 02 Oct 2018 at 14:34:16 (+0200), Peter Zijlstra wrote: > On Wed, Sep 12, 2018 at 10:13:00AM +0100, Quentin Perret wrote: > > In order to make sure Energy Aware Scheduling (EAS) doesn't hurt > > systems not using it, add a new sched_feat, called ENERGY_AWARE, > > guarding the access to

Re: [PATCH v7 05/14] sched: Introduce a sched_feat for Energy Aware Scheduling

2018-10-02 Thread Peter Zijlstra
On Wed, Sep 12, 2018 at 10:13:00AM +0100, Quentin Perret wrote: > In order to make sure Energy Aware Scheduling (EAS) doesn't hurt > systems not using it, add a new sched_feat, called ENERGY_AWARE, > guarding the access to EAS code paths. > > Signed-off-by: Quentin Perret > --- >

Re: [PATCH v7 05/14] sched: Introduce a sched_feat for Energy Aware Scheduling

2018-10-02 Thread Peter Zijlstra
On Wed, Sep 12, 2018 at 10:13:00AM +0100, Quentin Perret wrote: > In order to make sure Energy Aware Scheduling (EAS) doesn't hurt > systems not using it, add a new sched_feat, called ENERGY_AWARE, > guarding the access to EAS code paths. > > Signed-off-by: Quentin Perret > --- >

[PATCH v7 05/14] sched: Introduce a sched_feat for Energy Aware Scheduling

2018-09-12 Thread Quentin Perret
In order to make sure Energy Aware Scheduling (EAS) doesn't hurt systems not using it, add a new sched_feat, called ENERGY_AWARE, guarding the access to EAS code paths. Signed-off-by: Quentin Perret --- kernel/sched/features.h | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v7 05/14] sched: Introduce a sched_feat for Energy Aware Scheduling

2018-09-12 Thread Quentin Perret
In order to make sure Energy Aware Scheduling (EAS) doesn't hurt systems not using it, add a new sched_feat, called ENERGY_AWARE, guarding the access to EAS code paths. Signed-off-by: Quentin Perret --- kernel/sched/features.h | 7 +++ 1 file changed, 7 insertions(+) diff --git