Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-02-16 Thread Stephane Eranian
On Sat, Feb 16, 2013 at 3:45 AM, Benjamin Herrenschmidt wrote: > On Fri, 2013-02-15 at 11:46 -0800, Sukadev Bhattiprolu wrote: >> >> POWER could use an additional field: >> >> mem_deratmiss:1 > > If you want to make that field more "generic" make it "lvl1_tlb_miss", > ie,

Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-02-16 Thread Ingo Molnar
* Benjamin Herrenschmidt wrote: > On Fri, 2013-02-15 at 11:46 -0800, Sukadev Bhattiprolu wrote: > > > > POWER could use an additional field: > > > > mem_deratmiss:1 > > If you want to make that field more "generic" make it > "lvl1_tlb_miss", ie, a miss in the

Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-02-16 Thread Ingo Molnar
* Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Fri, 2013-02-15 at 11:46 -0800, Sukadev Bhattiprolu wrote: POWER could use an additional field: mem_deratmiss:1 If you want to make that field more generic make it lvl1_tlb_miss, ie, a miss in the

Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-02-16 Thread Stephane Eranian
On Sat, Feb 16, 2013 at 3:45 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Fri, 2013-02-15 at 11:46 -0800, Sukadev Bhattiprolu wrote: POWER could use an additional field: mem_deratmiss:1 If you want to make that field more generic make it

Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-02-15 Thread Benjamin Herrenschmidt
On Fri, 2013-02-15 at 11:46 -0800, Sukadev Bhattiprolu wrote: > > POWER could use an additional field: > > mem_deratmiss:1 If you want to make that field more "generic" make it "lvl1_tlb_miss", ie, a miss in the internal "level 1" TLB which is the smallest/fastest TLB

Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-02-15 Thread Sukadev Bhattiprolu
> > * Stephane Eranian wrote: > > > This patch adds PERF_SAMPLE_DSRC. > > > > PERF_SAMPLE_DSRC collects the data source, i.e., where > > did the data associated with the sampled instruction > > come from. Information is stored in a perf_mem_dsrc > > structure. It contains opcode, mem level,

Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-02-15 Thread Sukadev Bhattiprolu
* Stephane Eranian eran...@google.com wrote: This patch adds PERF_SAMPLE_DSRC. PERF_SAMPLE_DSRC collects the data source, i.e., where did the data associated with the sampled instruction come from. Information is stored in a perf_mem_dsrc structure. It contains opcode, mem level,

Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-02-15 Thread Benjamin Herrenschmidt
On Fri, 2013-02-15 at 11:46 -0800, Sukadev Bhattiprolu wrote: POWER could use an additional field: mem_deratmiss:1 If you want to make that field more generic make it lvl1_tlb_miss, ie, a miss in the internal level 1 TLB which is the smallest/fastest TLB level in the

Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-01-29 Thread Michael Ellerman
On Fri, 2013-01-25 at 16:30 +0100, Stephane Eranian wrote: > On Fri, Jan 25, 2013 at 10:01 AM, Ingo Molnar wrote: > > > > Would be nice to get feedback from PowerPC folks to see how well > > this matches their memory profiling hw capabilities? > > > I agree, I tried to remain as generic as

Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-01-29 Thread Michael Ellerman
On Fri, 2013-01-25 at 16:30 +0100, Stephane Eranian wrote: On Fri, Jan 25, 2013 at 10:01 AM, Ingo Molnar mi...@kernel.org wrote: Would be nice to get feedback from PowerPC folks to see how well this matches their memory profiling hw capabilities? I agree, I tried to remain as generic as

Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-01-25 Thread Stephane Eranian
On Fri, Jan 25, 2013 at 10:01 AM, Ingo Molnar wrote: > > * Stephane Eranian wrote: > >> This patch adds PERF_SAMPLE_DSRC. >> >> PERF_SAMPLE_DSRC collects the data source, i.e., where >> did the data associated with the sampled instruction >> come from. Information is stored in a perf_mem_dsrc >>

Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-01-25 Thread Ingo Molnar
* Stephane Eranian wrote: > This patch adds PERF_SAMPLE_DSRC. > > PERF_SAMPLE_DSRC collects the data source, i.e., where > did the data associated with the sampled instruction > come from. Information is stored in a perf_mem_dsrc > structure. It contains opcode, mem level, tlb, snoop, > lock

Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-01-25 Thread Ingo Molnar
* Stephane Eranian eran...@google.com wrote: This patch adds PERF_SAMPLE_DSRC. PERF_SAMPLE_DSRC collects the data source, i.e., where did the data associated with the sampled instruction come from. Information is stored in a perf_mem_dsrc structure. It contains opcode, mem level, tlb,

Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-01-25 Thread Stephane Eranian
On Fri, Jan 25, 2013 at 10:01 AM, Ingo Molnar mi...@kernel.org wrote: * Stephane Eranian eran...@google.com wrote: This patch adds PERF_SAMPLE_DSRC. PERF_SAMPLE_DSRC collects the data source, i.e., where did the data associated with the sampled instruction come from. Information is stored

[PATCH v7 07/18] perf: add generic memory sampling interface

2013-01-24 Thread Stephane Eranian
This patch adds PERF_SAMPLE_DSRC. PERF_SAMPLE_DSRC collects the data source, i.e., where did the data associated with the sampled instruction come from. Information is stored in a perf_mem_dsrc structure. It contains opcode, mem level, tlb, snoop, lock information, subject to availability in

[PATCH v7 07/18] perf: add generic memory sampling interface

2013-01-24 Thread Stephane Eranian
This patch adds PERF_SAMPLE_DSRC. PERF_SAMPLE_DSRC collects the data source, i.e., where did the data associated with the sampled instruction come from. Information is stored in a perf_mem_dsrc structure. It contains opcode, mem level, tlb, snoop, lock information, subject to availability in