Re: [PATCH v7 08/12] media: uvcvideo: Use dev_ printk aliases

2020-12-24 Thread Laurent Pinchart
Hi Andy, On Thu, Dec 24, 2020 at 02:59:34PM +0200, Andy Shevchenko wrote: > On Wed, Dec 23, 2020 at 3:39 PM Ricardo Ribalda wrote: > > > > Replace all the uses of printk() and uvc_printk() with its > > equivalent dev_ alias macros. > > > Modify uvc_warn_once() macro to use dev_info instead

Re: [PATCH v7 08/12] media: uvcvideo: Use dev_ printk aliases

2020-12-24 Thread Andy Shevchenko
On Wed, Dec 23, 2020 at 3:39 PM Ricardo Ribalda wrote: > > Replace all the uses of printk() and uvc_printk() with its > equivalent dev_ alias macros. > Modify uvc_warn_once() macro to use dev_info instead printk(). ... > +#define uvc_warn_once(_dev, warn, fmt, ...)\

[PATCH v7 08/12] media: uvcvideo: Use dev_ printk aliases

2020-12-23 Thread Ricardo Ribalda
Replace all the uses of printk() and uvc_printk() with its equivalent dev_ alias macros. Modify uvc_warn_once() macro to use dev_info instead printk(). They are more standard across the kernel tree and provide more context about the error. Reviewed-by: Laurent Pinchart Suggested-by: Joe