Re: [PATCH v7 08/14] sched/topology: Disable EAS on inappropriate platforms

2018-10-04 Thread Quentin Perret
On Thursday 04 Oct 2018 at 11:38:48 (+0200), Peter Zijlstra wrote: > On Thu, Oct 04, 2018 at 10:10:48AM +0100, Quentin Perret wrote: > > On Wednesday 03 Oct 2018 at 18:27:19 (+0200), Peter Zijlstra wrote: > > > On Wed, Sep 12, 2018 at 10:13:03AM +0100, Quentin Perret wrote: > > > > @@ -288,6 +321,2

Re: [PATCH v7 08/14] sched/topology: Disable EAS on inappropriate platforms

2018-10-04 Thread Peter Zijlstra
On Thu, Oct 04, 2018 at 10:10:48AM +0100, Quentin Perret wrote: > On Wednesday 03 Oct 2018 at 18:27:19 (+0200), Peter Zijlstra wrote: > > On Wed, Sep 12, 2018 at 10:13:03AM +0100, Quentin Perret wrote: > > > @@ -288,6 +321,21 @@ static void build_perf_domains(const struct cpumask > > > *cpu_map) >

Re: [PATCH v7 08/14] sched/topology: Disable EAS on inappropriate platforms

2018-10-04 Thread Quentin Perret
On Wednesday 03 Oct 2018 at 18:27:19 (+0200), Peter Zijlstra wrote: > On Wed, Sep 12, 2018 at 10:13:03AM +0100, Quentin Perret wrote: > > @@ -288,6 +321,21 @@ static void build_perf_domains(const struct cpumask > > *cpu_map) > > goto free; > > tmp->next = pd; > >

Re: [PATCH v7 08/14] sched/topology: Disable EAS on inappropriate platforms

2018-10-03 Thread Peter Zijlstra
On Wed, Sep 12, 2018 at 10:13:03AM +0100, Quentin Perret wrote: > @@ -288,6 +321,21 @@ static void build_perf_domains(const struct cpumask > *cpu_map) > goto free; > tmp->next = pd; > pd = tmp; > + > + /* > + * Count perfor

[PATCH v7 08/14] sched/topology: Disable EAS on inappropriate platforms

2018-09-12 Thread Quentin Perret
Energy Aware Scheduling (EAS) in its current form is most relevant on platforms with asymmetric CPU topologies (e.g. Arm big.LITTLE) since this is where there is a lot of potential for saving energy through scheduling. This is particularly true since the Energy Model only includes the active power