Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-29 Thread Dave Young
On 12/29/13 at 01:05pm, Matt Fleming wrote: > On Wed, 25 Dec, at 11:32:05AM, Dave Young wrote: > > > > Matt, if you want to remove the map[0] please fold below one line > > patch? I have no strong opinion. > > > > Index: linux/arch/x86/include/asm/efi.h > >

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-29 Thread Matt Fleming
On Wed, 25 Dec, at 11:32:05AM, Dave Young wrote: > > Matt, if you want to remove the map[0] please fold below one line > patch? I have no strong opinion. > > Index: linux/arch/x86/include/asm/efi.h > === > ---

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-29 Thread Matt Fleming
On Wed, 25 Dec, at 11:32:05AM, Dave Young wrote: Matt, if you want to remove the map[0] please fold below one line patch? I have no strong opinion. Index: linux/arch/x86/include/asm/efi.h === ---

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-29 Thread Dave Young
On 12/29/13 at 01:05pm, Matt Fleming wrote: On Wed, 25 Dec, at 11:32:05AM, Dave Young wrote: Matt, if you want to remove the map[0] please fold below one line patch? I have no strong opinion. Index: linux/arch/x86/include/asm/efi.h

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-24 Thread Dave Young
On 12/25/13 at 11:12am, Dave Young wrote: > On 12/23/13 at 08:07am, Matt Fleming wrote: > > On Mon, 23 Dec, at 10:09:58AM, Dave Young wrote: > > > On 12/21/13 at 04:06pm, Matt Fleming wrote: > > > > On Fri, 20 Dec, at 06:02:19PM, Dave Young wrote: > > > > > @@ -133,6 +133,19 @@ extern void

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-24 Thread Dave Young
On 12/23/13 at 08:07am, Matt Fleming wrote: > On Mon, 23 Dec, at 10:09:58AM, Dave Young wrote: > > On 12/21/13 at 04:06pm, Matt Fleming wrote: > > > On Fri, 20 Dec, at 06:02:19PM, Dave Young wrote: > > > > @@ -133,6 +133,19 @@ extern void efi_sync_low_kernel_mappings(void); > > > > extern void

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-24 Thread Dave Young
On 12/23/13 at 08:07am, Matt Fleming wrote: On Mon, 23 Dec, at 10:09:58AM, Dave Young wrote: On 12/21/13 at 04:06pm, Matt Fleming wrote: On Fri, 20 Dec, at 06:02:19PM, Dave Young wrote: @@ -133,6 +133,19 @@ extern void efi_sync_low_kernel_mappings(void); extern void

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-24 Thread Dave Young
On 12/25/13 at 11:12am, Dave Young wrote: On 12/23/13 at 08:07am, Matt Fleming wrote: On Mon, 23 Dec, at 10:09:58AM, Dave Young wrote: On 12/21/13 at 04:06pm, Matt Fleming wrote: On Fri, 20 Dec, at 06:02:19PM, Dave Young wrote: @@ -133,6 +133,19 @@ extern void

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-23 Thread Matt Fleming
On Mon, 23 Dec, at 10:09:58AM, Dave Young wrote: > On 12/21/13 at 04:06pm, Matt Fleming wrote: > > On Fri, 20 Dec, at 06:02:19PM, Dave Young wrote: > > > @@ -133,6 +133,19 @@ extern void efi_sync_low_kernel_mappings(void); > > > extern void efi_setup_page_tables(void); > > > extern void __init

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-23 Thread Matt Fleming
On Mon, 23 Dec, at 10:09:58AM, Dave Young wrote: On 12/21/13 at 04:06pm, Matt Fleming wrote: On Fri, 20 Dec, at 06:02:19PM, Dave Young wrote: @@ -133,6 +133,19 @@ extern void efi_sync_low_kernel_mappings(void); extern void efi_setup_page_tables(void); extern void __init

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-22 Thread Dave Young
> > Do we actually need the 'map' entry in efi_setup_data now that you're > > passing it via efi_info (which is much better approach!)? Also, we don't > > need the global nr_efi_runtime_map or efi_runtime_map variables now, > > right? > > The map is still necessary because we need store the map

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-22 Thread Dave Young
On 12/21/13 at 04:06pm, Matt Fleming wrote: > On Fri, 20 Dec, at 06:02:19PM, Dave Young wrote: > > @@ -133,6 +133,19 @@ extern void efi_sync_low_kernel_mappings(void); > > extern void efi_setup_page_tables(void); > > extern void __init old_map_region(efi_memory_desc_t *md); > > > > +struct

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-22 Thread Dave Young
> > + if (data) > > + early_memunmap(data, sizeof(*data)); > > #ifdef CONFIG_X86_32 > > if (tmp >> 32) { > > pr_err("EFI data located above 4GB, disabling EFI.\n"); > > This isn't correct, and means we now won't trigger this pr_err() if

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-22 Thread Dave Young
+ if (data) + early_memunmap(data, sizeof(*data)); #ifdef CONFIG_X86_32 if (tmp 32) { pr_err(EFI data located above 4GB, disabling EFI.\n); This isn't correct, and means we now won't trigger this pr_err() if booting a

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-22 Thread Dave Young
On 12/21/13 at 04:06pm, Matt Fleming wrote: On Fri, 20 Dec, at 06:02:19PM, Dave Young wrote: @@ -133,6 +133,19 @@ extern void efi_sync_low_kernel_mappings(void); extern void efi_setup_page_tables(void); extern void __init old_map_region(efi_memory_desc_t *md); +struct efi_setup_data

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-22 Thread Dave Young
Do we actually need the 'map' entry in efi_setup_data now that you're passing it via efi_info (which is much better approach!)? Also, we don't need the global nr_efi_runtime_map or efi_runtime_map variables now, right? The map is still necessary because we need store the map somewhere

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-21 Thread Matt Fleming
On Fri, 20 Dec, at 06:02:19PM, Dave Young wrote: > @@ -133,6 +133,19 @@ extern void efi_sync_low_kernel_mappings(void); > extern void efi_setup_page_tables(void); > extern void __init old_map_region(efi_memory_desc_t *md); > > +struct efi_setup_data { > + u64 fw_vendor; > + u64

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-21 Thread Matt Fleming
On Fri, 20 Dec, at 06:02:19PM, Dave Young wrote: > Add a new setup_data type SETUP_EFI for kexec use. > Passing the saved fw_vendor, runtime, config tables and efi runtime mappings. > > When entering virtual mode, directly mapping the efi runtime ragions which > we passed in previously. And skip

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-21 Thread Matt Fleming
On Fri, 20 Dec, at 06:02:19PM, Dave Young wrote: Add a new setup_data type SETUP_EFI for kexec use. Passing the saved fw_vendor, runtime, config tables and efi runtime mappings. When entering virtual mode, directly mapping the efi runtime ragions which we passed in previously. And skip the

Re: [PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-21 Thread Matt Fleming
On Fri, 20 Dec, at 06:02:19PM, Dave Young wrote: @@ -133,6 +133,19 @@ extern void efi_sync_low_kernel_mappings(void); extern void efi_setup_page_tables(void); extern void __init old_map_region(efi_memory_desc_t *md); +struct efi_setup_data { + u64 fw_vendor; + u64 runtime; +

[PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-20 Thread Dave Young
Add a new setup_data type SETUP_EFI for kexec use. Passing the saved fw_vendor, runtime, config tables and efi runtime mappings. When entering virtual mode, directly mapping the efi runtime ragions which we passed in previously. And skip the step to call SetVirtualAddressMap. Specially for HP

[PATCH v7 09/12] efi: passing kexec necessary efi data via setup_data

2013-12-20 Thread Dave Young
Add a new setup_data type SETUP_EFI for kexec use. Passing the saved fw_vendor, runtime, config tables and efi runtime mappings. When entering virtual mode, directly mapping the efi runtime ragions which we passed in previously. And skip the step to call SetVirtualAddressMap. Specially for HP