Re: [PATCH v7 1/5] leds: flash: Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH

2020-11-24 Thread Jacek Anaszewski
On 11/24/20 7:08 AM, Gene Chen wrote: [...] This function should be placed after #ifdef block because its shape is the same for both cases. +static inline void led_classdev_flash_unregister(struct led_classdev_flash *fled_cdev) {}; +static inline int

Re: [PATCH v7 1/5] leds: flash: Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH

2020-11-23 Thread Gene Chen
Jacek Anaszewski 於 2020年11月24日 週二 上午5:07寫道: > > On 11/23/20 4:20 AM, Gene Chen wrote: > > Jacek Anaszewski 於 2020年11月20日 週五 上午6:29寫道: > >> > >> Hi Gene, > >> > >> On 11/18/20 11:47 AM, Gene Chen wrote: > >>> From: Gene Chen > >>> > >>> Add flash registration with undefined

Re: [PATCH v7 1/5] leds: flash: Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH

2020-11-23 Thread Jacek Anaszewski
On 11/23/20 4:20 AM, Gene Chen wrote: Jacek Anaszewski 於 2020年11月20日 週五 上午6:29寫道: Hi Gene, On 11/18/20 11:47 AM, Gene Chen wrote: From: Gene Chen Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH Signed-off-by: Gene Chen --- include/linux/led-class-flash.h | 36

Re: [PATCH v7 1/5] leds: flash: Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH

2020-11-22 Thread Gene Chen
Jacek Anaszewski 於 2020年11月20日 週五 上午6:29寫道: > > Hi Gene, > > On 11/18/20 11:47 AM, Gene Chen wrote: > > From: Gene Chen > > > > Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH > > > > Signed-off-by: Gene Chen > > --- > > include/linux/led-class-flash.h | 36

Re: [PATCH v7 1/5] leds: flash: Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH

2020-11-19 Thread Jacek Anaszewski
Hi Gene, On 11/18/20 11:47 AM, Gene Chen wrote: From: Gene Chen Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH Signed-off-by: Gene Chen --- include/linux/led-class-flash.h | 36 1 file changed, 36 insertions(+) diff --git

Re: [PATCH v7 1/5] leds: flash: Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH

2020-11-18 Thread kernel test robot
Hi Gene, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on pavel-linux-leds/for-next] [also build test WARNING on robh/for-next linus/master v5.10-rc4 next-20201118] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

[PATCH v7 1/5] leds: flash: Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH

2020-11-18 Thread Gene Chen
From: Gene Chen Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH Signed-off-by: Gene Chen --- include/linux/led-class-flash.h | 36 1 file changed, 36 insertions(+) diff --git a/include/linux/led-class-flash.h