Re: [PATCH v7 10/26] x86/insn-eval: Add utility functions to get segment selector

2017-06-19 Thread Borislav Petkov
On Thu, Jun 15, 2017 at 12:04:21PM -0700, Ricardo Neri wrote: > On Thu, 2017-06-15 at 11:37 -0700, Ricardo Neri wrote: > > > Yuck, didn't we talk about this already? > > > > I am sorry Borislav. I thought you agreed that I could use the values > > of > > the segment override prefixes to identify

Re: [PATCH v7 10/26] x86/insn-eval: Add utility functions to get segment selector

2017-06-19 Thread Borislav Petkov
On Thu, Jun 15, 2017 at 12:04:21PM -0700, Ricardo Neri wrote: > On Thu, 2017-06-15 at 11:37 -0700, Ricardo Neri wrote: > > > Yuck, didn't we talk about this already? > > > > I am sorry Borislav. I thought you agreed that I could use the values > > of > > the segment override prefixes to identify

Re: [PATCH v7 10/26] x86/insn-eval: Add utility functions to get segment selector

2017-06-19 Thread Borislav Petkov
On Thu, Jun 15, 2017 at 11:37:51AM -0700, Ricardo Neri wrote: > Wouldn't this be ending up mixing the actual segment register and > segment register overrides? I plan to have a function that parses the > segment override prefixes and returns SEG_REG_CS/DS/ES/FS/GS or > SEG_REG_IGNORE for long mode

Re: [PATCH v7 10/26] x86/insn-eval: Add utility functions to get segment selector

2017-06-19 Thread Borislav Petkov
On Thu, Jun 15, 2017 at 11:37:51AM -0700, Ricardo Neri wrote: > Wouldn't this be ending up mixing the actual segment register and > segment register overrides? I plan to have a function that parses the > segment override prefixes and returns SEG_REG_CS/DS/ES/FS/GS or > SEG_REG_IGNORE for long mode

Re: [PATCH v7 10/26] x86/insn-eval: Add utility functions to get segment selector

2017-06-15 Thread Ricardo Neri
On Thu, 2017-06-15 at 11:37 -0700, Ricardo Neri wrote: > > Yuck, didn't we talk about this already? > > I am sorry Borislav. I thought you agreed that I could use the values > of > the segment override prefixes to identify the segment registers [1]. This time with the reference: [1].

Re: [PATCH v7 10/26] x86/insn-eval: Add utility functions to get segment selector

2017-06-15 Thread Ricardo Neri
On Thu, 2017-06-15 at 11:37 -0700, Ricardo Neri wrote: > > Yuck, didn't we talk about this already? > > I am sorry Borislav. I thought you agreed that I could use the values > of > the segment override prefixes to identify the segment registers [1]. This time with the reference: [1].

Re: [PATCH v7 10/26] x86/insn-eval: Add utility functions to get segment selector

2017-06-15 Thread Ricardo Neri
On Tue, 2017-05-30 at 12:35 +0200, Borislav Petkov wrote: > On Fri, May 05, 2017 at 11:17:08AM -0700, Ricardo Neri wrote: > > When computing a linear address and segmentation is used, we need to know > > the base address of the segment involved in the computation. In most of > > the cases, the

Re: [PATCH v7 10/26] x86/insn-eval: Add utility functions to get segment selector

2017-06-15 Thread Ricardo Neri
On Tue, 2017-05-30 at 12:35 +0200, Borislav Petkov wrote: > On Fri, May 05, 2017 at 11:17:08AM -0700, Ricardo Neri wrote: > > When computing a linear address and segmentation is used, we need to know > > the base address of the segment involved in the computation. In most of > > the cases, the

Re: [PATCH v7 10/26] x86/insn-eval: Add utility functions to get segment selector

2017-05-30 Thread Borislav Petkov
On Fri, May 05, 2017 at 11:17:08AM -0700, Ricardo Neri wrote: > When computing a linear address and segmentation is used, we need to know > the base address of the segment involved in the computation. In most of > the cases, the segment base address will be zero as in USER_DS/USER32_DS. > However,

Re: [PATCH v7 10/26] x86/insn-eval: Add utility functions to get segment selector

2017-05-30 Thread Borislav Petkov
On Fri, May 05, 2017 at 11:17:08AM -0700, Ricardo Neri wrote: > When computing a linear address and segmentation is used, we need to know > the base address of the segment involved in the computation. In most of > the cases, the segment base address will be zero as in USER_DS/USER32_DS. > However,

[PATCH v7 10/26] x86/insn-eval: Add utility functions to get segment selector

2017-05-05 Thread Ricardo Neri
When computing a linear address and segmentation is used, we need to know the base address of the segment involved in the computation. In most of the cases, the segment base address will be zero as in USER_DS/USER32_DS. However, it may be possible that a user space program defines its own segments

[PATCH v7 10/26] x86/insn-eval: Add utility functions to get segment selector

2017-05-05 Thread Ricardo Neri
When computing a linear address and segmentation is used, we need to know the base address of the segment involved in the computation. In most of the cases, the segment base address will be zero as in USER_DS/USER32_DS. However, it may be possible that a user space program defines its own segments