Re: [PATCH v7 12/22] ext2: Remove ext2_xip_verify_sb()

2014-04-10 Thread Jan Kara
On Thu 10-04-14 10:22:54, Matthew Wilcox wrote: > On Wed, Apr 09, 2014 at 11:52:54AM +0200, Jan Kara wrote: > > > - if ((sbi->s_mount_opt ^ old_mount_opt) & EXT2_MOUNT_XIP) { > > > + if ((sbi->s_mount_opt ^ old_opts.s_mount_opt) & EXT2_MOUNT_XIP) { > > > ext2_msg(sb, KERN_WARNING, "warnin

Re: [PATCH v7 12/22] ext2: Remove ext2_xip_verify_sb()

2014-04-10 Thread Matthew Wilcox
On Wed, Apr 09, 2014 at 11:52:54AM +0200, Jan Kara wrote: > > - if ((sbi->s_mount_opt ^ old_mount_opt) & EXT2_MOUNT_XIP) { > > + if ((sbi->s_mount_opt ^ old_opts.s_mount_opt) & EXT2_MOUNT_XIP) { > > ext2_msg(sb, KERN_WARNING, "warning: refusing change of " > > "

Re: [PATCH v7 12/22] ext2: Remove ext2_xip_verify_sb()

2014-04-09 Thread Jan Kara
On Sun 23-03-14 15:08:38, Matthew Wilcox wrote: > Jan Kara pointed out that calling ext2_xip_verify_sb() in ext2_remount() > doesn't make sense, since changing the XIP option on remount isn't > allowed. It also doesn't make sense to re-check whether blocksize is > supported since it can't change b

[PATCH v7 12/22] ext2: Remove ext2_xip_verify_sb()

2014-03-23 Thread Matthew Wilcox
Jan Kara pointed out that calling ext2_xip_verify_sb() in ext2_remount() doesn't make sense, since changing the XIP option on remount isn't allowed. It also doesn't make sense to re-check whether blocksize is supported since it can't change between mounts. Replace the call to ext2_xip_verify_sb()