Re: [PATCH v7 13/14] selftests/vm: test flag is broken

2021-01-25 Thread Pavel Tatashin
On Sun, Jan 24, 2021 at 6:03 PM John Hubbard wrote: > > On 1/21/21 7:37 PM, Pavel Tatashin wrote: > > In gup_test both gup_flags and test_flags use the same flags field. > > This is broken. > > > > Farther, in the actual gup_test.c all the passed gup_flags are erased and > > unconditionally replac

Re: [PATCH v7 13/14] selftests/vm: test flag is broken

2021-01-24 Thread John Hubbard
On 1/21/21 7:37 PM, Pavel Tatashin wrote: In gup_test both gup_flags and test_flags use the same flags field. This is broken. Farther, in the actual gup_test.c all the passed gup_flags are erased and unconditionally replaced with FOLL_WRITE. Which means that test_flags are ignored, and code lik

[PATCH v7 13/14] selftests/vm: test flag is broken

2021-01-21 Thread Pavel Tatashin
In gup_test both gup_flags and test_flags use the same flags field. This is broken. Farther, in the actual gup_test.c all the passed gup_flags are erased and unconditionally replaced with FOLL_WRITE. Which means that test_flags are ignored, and code like this always performs pin dump test: 155