Re: [PATCH v7 15/17] tpm: introduce tpm_chip_start() and tpm_chip_stop()

2018-11-16 Thread Jarkko Sakkinen
On Tue, Nov 13, 2018 at 08:56:51PM -0500, Stefan Berger wrote: > On 11/13/18 5:34 PM, Stefan Berger wrote: > > On 11/13/18 1:36 PM, Jarkko Sakkinen wrote: > > > Encapsulate power gating and locality functionality to tpm_chip_start() > > > and tpm_chip_stop() in order to clean up the branching mess

Re: [PATCH v7 15/17] tpm: introduce tpm_chip_start() and tpm_chip_stop()

2018-11-15 Thread Jarkko Sakkinen
On Tue, Nov 13, 2018 at 05:34:54PM -0500, Stefan Berger wrote: > On 11/13/18 1:36 PM, Jarkko Sakkinen wrote: > > Encapsulate power gating and locality functionality to tpm_chip_start() > > and tpm_chip_stop() in order to clean up the branching mess in > > tpm_transmit(). > > > I ran the vtpm prox

Re: [PATCH v7 15/17] tpm: introduce tpm_chip_start() and tpm_chip_stop()

2018-11-13 Thread Stefan Berger
On 11/13/18 5:34 PM, Stefan Berger wrote: On 11/13/18 1:36 PM, Jarkko Sakkinen wrote: Encapsulate power gating and locality functionality to tpm_chip_start() and tpm_chip_stop() in order to clean up the branching mess in tpm_transmit(). I ran the vtpm proxy test suite on this series and got t

Re: [PATCH v7 15/17] tpm: introduce tpm_chip_start() and tpm_chip_stop()

2018-11-13 Thread Stefan Berger
On 11/13/18 1:36 PM, Jarkko Sakkinen wrote: Encapsulate power gating and locality functionality to tpm_chip_start() and tpm_chip_stop() in order to clean up the branching mess in tpm_transmit(). Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-chip.c | 110

Re: [PATCH v7 15/17] tpm: introduce tpm_chip_start() and tpm_chip_stop()

2018-11-13 Thread Stefan Berger
On 11/13/18 1:36 PM, Jarkko Sakkinen wrote: Encapsulate power gating and locality functionality to tpm_chip_start() and tpm_chip_stop() in order to clean up the branching mess in tpm_transmit(). Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-chip.c | 110

Re: [PATCH v7 15/17] tpm: introduce tpm_chip_start() and tpm_chip_stop()

2018-11-13 Thread Stefan Berger
On 11/13/18 1:36 PM, Jarkko Sakkinen wrote: Encapsulate power gating and locality functionality to tpm_chip_start() and tpm_chip_stop() in order to clean up the branching mess in tpm_transmit(). I ran the vtpm proxy test suite on this series and got this error when running it with 'make check

Re: [PATCH v7 15/17] tpm: introduce tpm_chip_start() and tpm_chip_stop()

2018-11-13 Thread Stefan Berger
On 11/13/18 1:36 PM, Jarkko Sakkinen wrote: Encapsulate power gating and locality functionality to tpm_chip_start() and tpm_chip_stop() in order to clean up the branching mess in tpm_transmit(). Signed-off-by: Jarkko Sakkinen Reviewed-by: Stefan Berger --- drivers/char/tpm/tpm-chip.c

[PATCH v7 15/17] tpm: introduce tpm_chip_start() and tpm_chip_stop()

2018-11-13 Thread Jarkko Sakkinen
Encapsulate power gating and locality functionality to tpm_chip_start() and tpm_chip_stop() in order to clean up the branching mess in tpm_transmit(). Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-chip.c | 110 +++ drivers/char/tpm/tpm-interface.c | 87